Coder Social home page Coder Social logo

Comments (7)

WardBrian avatar WardBrian commented on May 29, 2024

The tolerance is a hard coded value here: https://github.com/stan-dev/math/blob/46f3c59e63851451ed1bf9b64c8f57c89fa49e8e/stan/math/prim/err/constraint_tolerance.hpp#L12

It would be nice if this was at least a #define so we could override it easily at compile time.

from bridgestan.

mjhajharia avatar mjhajharia commented on May 29, 2024

okay makes sense, yeah that's unfortunate, for high dimensional simplexes this would definitely keep creating problems.

from bridgestan.

WardBrian avatar WardBrian commented on May 29, 2024

I think using more sig_figs in CmdStan (or CmdStan offering a binary format which has full double precision) are probably the best “solutions” for now, but it might be worth opening an issue in Stan-Dev/math about making that constant something configurable

from bridgestan.

sethaxen avatar sethaxen commented on May 29, 2024

Is there a compile flag for disabling this check entirely?

from bridgestan.

roualdes avatar roualdes commented on May 29, 2024

From what I see, there is not a flag for disabling this. @WardBrian would you mind filing an issue in Stan Math?

from bridgestan.

WardBrian avatar WardBrian commented on May 29, 2024

I think the issue @mjhajharia opened for a configurable tolerance is better than a flag, since one could just set it to a very high tolerance and effectively disable it that way

from bridgestan.

WardBrian avatar WardBrian commented on May 29, 2024

The next version of Stan will let this be configured at compile time

from bridgestan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.