.ion-alpha-scroll height increases ! about ionic2-alpha-scroll

[rossmartin]

Thanks for letting me know and sorry for the delay I went to a friends wedding this weekend. I haven't updated this component for Ionic 2 RC0 so it is possible that is why you are experiencing this. I'll look into it this week.

[julianlecalvez]

Hi!
No problem ! But i don't know if it's because of ionic 2 RC or if I'm not using it in a proper way :s
Thanks for checking on it, and I'll let you know if I find something as well ;)

[julianlecalvez]

ok I found something.
I have a <ion-searchbar></ion-searchbar> just above the list inside the ion-content.
It doesn't work with this search bar, but it works when I remove it. :(

EDIT:
it doesn't seem to be the search bar directly. If I put a margin-top on the ion-alpha-scroll. it starts to fail. Otherwise it works. I guess it's a calculation thing.

.ion-alpha-scroll {
        margin-top: 60px;
}

[julianlecalvez]

ok so far I found a quick trick, but I don't think it's optimal.
The problem is because I tried to put another thing inside the <ion-content>
So, to avoid that and keep the alpha-scroll alone, I added an <ion-header-bar> BEFORE the <ion-content>, and I calculate the new size of the content at load.
It works but I think there's something in the plugin calculation which causes that if there's another element inside the <ion-content>.

Julian

[rossmartin]

Hey I haven't forgot about this but I've been so busy lately. Also I'm trying to get a personal app updated from Ionic 2 beta 11 to RC0 and it has been a real pain so far. I've only had about an hour to commit to the upgrade but once I'm done I'll be on this issue.

Thanks.

[piuen0]

I tried to edit below lines in ion-alpha-scroll.js, and the problem fixed, see if it works for you.

*Changed height: dimensions.scrollHeight + 'px' to height: dimensions.contentHeight + 'px'

//line 62
IonAlphaScroll.prototype.calculateScrollDimensions = function () {
  var dimensions = this._content.getContentDimensions();
  return {
    height: dimensions.contentHeight + 'px',
    width: (dimensions.contentWidth - 20) + 'px'
  };
};

[rossmartin]

@piuen0 Thanks I'll take a look. I know the latest rc.4 brought some changes with it that has broken this component again :~(

[piuen0]

@rossmartin Thanks for your effort to build this repo! This is useful

[rossmartin]

This is solved via 26a4fae