Coder Social home page Coder Social logo

Comments (6)

hadifarnoud avatar hadifarnoud commented on August 14, 2024 2

what you're referring to is UI direction. looks like CKeditor5 does not have directional buttons as CK4. it's either the entire text RTL or LTR. That is a significant issue as you may want to enter English or any other LTR text right in the middle of your article.

I did not find any way of doing this in current CK5
ckeditor/ckeditor5#8989

from strapi-plugin-ckeditor5.

AbobkerElaghel avatar AbobkerElaghel commented on August 14, 2024 2

Any Update on This??
because the Text Part feature does not change the direction of the content selected.

As you can see Here in the output of CKeditor5 the first text on highlighted (selected from language dropbox) as English when editing in Ckeeditor5

<p>
<span lang=\"en\" dir=\"ltr\">ENGLISH</span>
</p>

This one is highlighted in Arabic from the language dropbox.

<p>
<span lang=\"ar\" dir=\"rtl\">عربي</span>
</p>

it adds a span tag inside whatever tag you heading or tag you selected and inside that span tag, it adds dir and lang to ar also which renders it useless and the dir effect will not take place.

the dir and lang attributes should be on the outer layer which is in this example the P tag and not a span inside the main tag

PLUS,
It clearly says in the ✨ Features section of the README File in this package that it does support automatic UI and content selection based on the language defined in the strapi user profile, but it does not. it always defaults to English.

ALSO: The CKEditor does not have a text direction option in the toolbar items options and I don't know why?? since you guys have the RTL Feature developed (coded) already when I hard code the Language of content to ar (Arabic) in the config/plugins.js file in strapi?.
So why you don't just add a toolbar item button to change the direction on runtime while the end user is writing the content in CKEditor5 Editor?
because you have the scenario where The content is mixed between two languages (Arabic/English) for example.

"@_sh/strapi-plugin-ckeditor": "^1.1.2",
"@strapi/plugin-i18n": "4.4.1",
"@strapi/plugin-users-permissions": "4.4.1",
"@strapi/provider-upload-cloudinary": "^4.4.1",
"@strapi/strapi": "4.4.1",
"pg": "^8.6.0",
"pg-connection-string": "^2.5.0"

 Node: 16.15.0

 Tried on both Dev and prod environments, error occurs on both.

from strapi-plugin-ckeditor5.

roslovets avatar roslovets commented on August 14, 2024 1

Hi! Seems like there is no special buttons for RTL and LRT in CKEditor 5. It should work automatically.

from strapi-plugin-ckeditor5.

Tboul avatar Tboul commented on August 14, 2024

Hi! Seems like there is no special buttons for RTL and LRT in CKEditor 5. It should work automatically.

It works automatically only when you select an RTL language (i.e Hebrew or Arabic) for the UI. so the change must come from the custom build which have to include the language feature.

from strapi-plugin-ckeditor5.

muhdlaziem avatar muhdlaziem commented on August 14, 2024

what you're referring to is UI direction. looks like CKeditor5 does not have directional buttons as CK4. it's either the entire text RTL or LTR. That is a significant issue as you may want to enter English or any other LTR text right in the middle of your article.

I did not find any way of doing this in current CK5 ckeditor/ckeditor5#8989

What's the update here? really need that feature

from strapi-plugin-ckeditor5.

muhdlaziem avatar muhdlaziem commented on August 14, 2024

Apparently there is a PR merged here ckeditor/ckeditor5#9074 said that.

Feature (language): Added language dropdown button to support text part language. Closes ckeditor/ckeditor5#8989.

Here is the documentation: https://ckeditor.com/docs/ckeditor5/latest/features/language.html

from strapi-plugin-ckeditor5.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.