Comments (4)
A quick browsing does not show me function needing refactoring because of complexity.
@rosenpin, do you have some in mind ?
from i3-agenda.
Please tell me if you think something else shall be done.
Before taking maintenance, I'd also like to add more testing (I quickly began with human_delta
which chocked:
def test_human_delta():
assert human_delta(dt.timedelta(0)) == "0m"
assert human_delta(dt.timedelta(minutes=1)) == "1m"
> assert human_delta(dt.timedelta(hours=1)) == "1h"
E AssertionError: assert '0m' == '1h'
E - 1h
E + 0m
).
I'll open a new PR based upon #89 for tests.
from i3-agenda.
Great find
I'll look into the PR and comment on everything once I get a chance (hopefully next few days)
Thanks!
from i3-agenda.
A quick browsing does not show me function needing refactoring because of complexity. @rosenpin, do you have some in mind ?
As a general rule, as mentioned in the issue description
Separate functions with 3+ indentation levels or over 15 lines
Some example I found include
- get_credentials
- get_callendar_ids
- get_all_events
- get_events_from_cache
- get_string
- get_future_events
from i3-agenda.
Related Issues (20)
- Error after upgrade HOT 1
- Limiting Size of Summary HOT 1
- Token revoked HOT 1
- refactor
- Suddenly "Bad Request" Error HOT 3
- Long-lasting Focus/Highlight Color HOT 1
- --today event conflicts with cache HOT 1
- help message for the --date-format flag is missleading
- scrolling on the bar module navigate the events HOT 1
- AUR i3-agenda-git installation - No module named 'config' HOT 3
- i3agenda_google_token.pickle not found HOT 2
- Crashes if .i3agenda dir doesn't exist when trying to read pickle file
- module 'pyparsing' has no attribute 'downcaseTokens' HOT 1
- Google Refresh Token error HOT 2
- Google Refresh Token error HOT 1
- aur package is installing lib files in /usr/bin HOT 1
- Add option to only show events if they are within X minutes
- Looking for maintainer HOT 4
- Add CD to auto upload new versions from master to pip
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from i3-agenda.