Coder Social home page Coder Social logo

Comments (3)

xhuan28 avatar xhuan28 commented on August 15, 2024

More information:
But the parameters can be set successfully through dictionary one by one. Is there anything wrong with the namespace?
e.g.

                ComposableNode(
                    package='my_package',
                    node_plugin='namespace::Class',
                    node_name='my_node',
                    parameters=[param_file_path,                    # no effect
                                         {'enabled_param1': 'true'}],)   # successfully

from launch_ros.

xhuan28 avatar xhuan28 commented on August 15, 2024

I have found out the root cause of this issue. It is caused by different naming rules between yaml file and direct dictionary parameter. A parameter from a yaml file will combine its name as a string like "/ns.my_node.ros__parameters.my_param", while passing a parameter as a dictionary directly, the name should be "my_param". Parameter system takes these two parameters for different parameters, not the same one. So the parameter from a yaml file will not override the default value to take effect.
I think we need to make the naming rule consistent among different parameter sources. I submit a PR#58. Please have a review. Thanks.

from launch_ros.

mabelzhang avatar mabelzhang commented on August 15, 2024

Related issue ros2/rclcpp#715

from launch_ros.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.