Coder Social home page Coder Social logo

Comments (3)

wjwwood avatar wjwwood commented on June 11, 2024 1

@Theosakamg looks like I missed that one (foo/_/bar) when updating the rules. Thanks for pointing it out! I'll open a pr to fix it.

As for the current implementation, it doesn't follow this design doc yet (the implementation is lagging behind the document). We'll replace that line with something like this:

node_->get_name() + "/_get_parameters",

Or something similar, so that it uses the / namespace separator and is "hidden".

If you have further comments, please open a new issue or comment on the original pr (#90). This issue is specifically about completing the EBNF (candidate implementation is in #96).

from design.

Theosakamg avatar Theosakamg commented on June 11, 2024

In design article it say :

must not have an underscore (_) followed by a forward slash (/), i.e. _/

https://github.com/ros2/design/blob/gh-pages/articles/115_topic_and_service_name_mapping.md#ros-2-topic-and-service-name-constraints

but in valid example :

foo/_/bar

https://github.com/ros2/design/blob/gh-pages/articles/115_topic_and_service_name_mapping.md#ros-2-name-examples

Can you clarify ?

from design.

Theosakamg avatar Theosakamg commented on June 11, 2024

ind design acticle it say :

must not contain any number of repeated underscores (_)

https://github.com/ros2/design/blob/gh-pages/articles/115_topic_and_service_name_mapping.md#ros-2-topic-and-service-name-constraints

but in current implementation of Parameter service :
node_->get_name() + "__get_parameters",
https://github.com/ros2/rclcpp/blob/5894a9cd4eb0371e380dcbac73b74efae353fde2/rclcpp/src/rclcpp/parameter_service.cpp

It is excluded of Service name of parameter stack ?

from design.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.