Coder Social home page Coder Social logo

Comments (5)

mirzashah avatar mirzashah commented on August 28, 2024

hey @cottsay, I'm the current maintainer of pluginlib. I'm looking into this now. If you could provide a simple test program that would be great. The unit tests for pluginlib and the underlying class_loader package should handle this situation.

from pluginlib.

mirzashah avatar mirzashah commented on August 28, 2024

You're right...it isn't being set any more. Not sure why that was removed and how things work without it. I'll investigate further.

from pluginlib.

cottsay avatar cottsay commented on August 28, 2024

Thanks for getting back to me so quickly, @mirzashah . I created a quick test package available at https://github.com/cottsay/pluginlib_test .

from pluginlib.

mirzashah avatar mirzashah commented on August 28, 2024

Fixed in 560ccbe. Simple fix to set that value. I don't think anybody noticed as the library is unloaded via another mechanism on ClassLoader destruction (destruction of the member class_loader::MultiLibraryClassLoader object takes care of this).

I've added a unit test for this case and realized I need to add in a few more unit tests. Let me know if this version works before I do a release.

from pluginlib.

cottsay avatar cottsay commented on August 28, 2024

Looks great @mirzashah, thanks for taking care of this so quickly. Looks like it solved the problem!

from pluginlib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.