Comments (4)
Thanks for filing this issue and providing details on the problem. Based on what you described, I suspect that it is related to this: 4e0f9ea
I had to remove the zstd-vendor meta-package because it was empty. I suspect that it is necessary to also add:
ROS_EXEC_DEPENDS:append = " zstd"
or simple replace the ROS_EXEC_DEPENDS:remove line with ALLOW_EMPTY="1" to ensure that the meta-package is created with an automatic dependency on zstd.
from meta-ros.
@robwoolley thanks for the answer!
However I tried both of these approaches now and non of them fixes the error.
from meta-ros.
@robwoolley I had to update the patch to make this work, the following patch file and bbappend file solves the issues:
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 6de89d205..c849fbc8e 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -2,6 +2,7 @@ cmake_minimum_required(VERSION 3.5)
project(mcap_vendor LANGUAGES C CXX ASM)
## Dependencies
+set(zstd_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/zstd)
find_package(ament_cmake REQUIRED)
find_package(zstd_vendor REQUIRED)
find_package(zstd REQUIRED)
@@ -30,19 +31,8 @@ endif()
## Define vendor macro
macro(build_mcap_vendor)
- include(FetchContent)
- fetchcontent_declare(mcap
- URL https://github.com/foxglove/mcap/archive/refs/tags/releases/cpp/v0.8.0.tar.gz
- URL_HASH SHA1=b44637791da2c9c1cec61a3ba6994f1ef63a228c # v0.8.0
- )
- fetchcontent_makeavailable(mcap)
-
- fetchcontent_declare(lz4
- GIT_REPOSITORY https://github.com/lz4/lz4.git
- GIT_TAG d44371841a2f1728a3f36839fd4b7e872d0927d3 # v1.9.3
- )
- fetchcontent_makeavailable(lz4)
-
+ set(mcap_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/mcap)
+ set(lz4_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/lz4)
file(GLOB _lz4_srcs
${lz4_SOURCE_DIR}/lib/*.c)
# Use Bitbake to fetch https://github.com/foxglove/mcap.git
FILESEXTRAPATHS:prepend := "${THISDIR}/${BPN}:"
#SRC_URI += "file://0001-CMakeLists.txt-fetch-uncrustify-with-bitbake-fetcher.patch"
SRC_URI += " \
git://github.com/foxglove/mcap.git;protocol=https;name=mcap;destsuffix=git/mcap;branch=main;lfs=0 \
git://github.com/lz4/lz4.git;protocol=https;name=lz4;destsuffix=git/lz4;branch=release \
git://github.com/facebook/zstd.git;protocol=https;name=zstd;destsuffix=git/zstd;branch=release \
file://0001-CMakeLists.txt-fetch-dependencies-with-bitbake-fetch.patch \
"
# releases/cpp/v0.8.0
SRCREV_mcap = "801c4ae3f34b23e9a27eb34b88ab7a0180d4b40f"
# v1.9.3
SRCREV_lz4 = "d44371841a2f1728a3f36839fd4b7e872d0927d3"
# v1.5.2
SRCREV_zstd = "e47e674cd09583ff0503f0f6defd6d23d8b718d3"
from meta-ros.
Thanks! I will try to get this merged in as soon as possible.
from meta-ros.
Related Issues (20)
- error: 'memset' is not a member of 'std'; HOT 2
- Turtlebot3 support is missing on ROS2 humble kirkstone due to ignition/gazebo dependency errors HOT 15
- meta-ros on jetson-nano-devkit HOT 2
- Apriltag patch does not work HOT 2
- rosidl linking error HOT 4
- Flashing ros-image-core-humble hangs for jetson-orin-nano-devkit HOT 4
- Cannot login jetson-orin-nano-devkit ros-image-core-humble HOT 5
- Could not find RenderSystem_GL plugin in configuring rviz-rendering. HOT 2
- HOST path is included in urdfdom package
- Issue with nav2-mppi-controller HOT 1
- Python packages missing HOT 1
- Missing license information about code inherited from elsewhere HOT 1
- ROS1 Noetic and Yocto Scarthgap with Python 3.12 HOT 1
- Installing error for clearpath-platform HOT 2
- Release plan HOT 7
- Missing or unbuildable dependency chain was: ['eigenpy', 'python3-scipy']
- Failed to compile (problem patching) HOT 1
- Failed to compile: zstd-vendor HOT 4
- Error building rmw-dds-common for raspberrypi0-wifi HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meta-ros.