Use of C++11 about class_loader

[mikaelarguedas]

Can you please clarify what version (or branch) of class_loader you are compiling as well as what version of ROS you are using ? Thanks

[kunaltyagi]

Oops, sorry for forgetting that. Melodic from rosinstall_generator ros_comm --rosdistro melodic --deps --tar > melodic-ros_comm.rosinstall

[mikaelarguedas]

Melodic targets only platforms that have c++14 as their default compiler option:
https://github.com/ros-infrastructure/rep/blob/master/rep-0003.rst#melodic-morenia-may-2018---may-2023
And assumes C++14 not C++98: https://github.com/ros-infrastructure/rep/blob/master/rep-0003.rst#melodic

Could you clarify your use case / setup?

[kunaltyagi]

I understand the fact that c++14 is the default compiler option on the target platforms.

In that case, should I go ahead with a PR on the rosbag repository for adding the definition explicitly? There's no harm in adding the c++ standard required. Our default compiler has c++14 support but not by default...

Thanks for the links. It seems I was stuck in the past

[mikaelarguedas]

There's no harm in adding the c++ standard required.

This will force users to compile the code with the standard hard-coded in the package. If users have compiler defaulting to a higher standard I don't think we should force a downgrade on them

In that case, should I go ahead with a PR on the rosbag repository for adding the definition explicitly?

The policy applies to the entire distribution, I don't think submitting patches to specific packages is a desired approach as this will introduce inconsistencies between packages of the same distribution.

Our default compiler has c++14 support but not by default...

Then I recommend you to pass the c++ standard explicitely to your build tool (or in its configuration if it supports it). e.g. MacOS users currently build by passing -DCMAKE_CXX_STANDARD=14 to their build tools

You can find a similar discussion at ros/catkin#936