Package failed with error "C2065: 'M_PI': undeclared identifier" about pointcloud_to_laserscan

[kenji-miyake]

Probably it's because the behavior of _USE_MATH_DEFINES is different between gcc and msvc? 🤔
https://docs.microsoft.com/en-us/cpp/c-runtime-library/math-constants?view=msvc-160

[XavierTrudeau]

That's right. Adding these lines to the header file also fixed it.
#define _USE_MATH_DEFINES // for C++
#include

I'm now getting a crash when trying to run the sample launch file. Both pointcloud_to_laserscan_node and laserscan_to_pointcloud_node crash upon launch :

[ERROR] [pointcloud_to_laserscan_node.EXE-3]: process has died [pid 7072, exit code 3221226505, cmd 'c:\nav2_ws\install\lib\pointcloud_to_laserscan\pointcloud_to_laserscan_node.EXE --ros-args -r __node:=pointcloud_to_laserscan -r __node:=pointcloud_to_laserscan --params-file C:\Users\xaviert\AppData\Local\Temp\launch_params_45izntrr -r cloud_in:=scanner/cloud -r scan:=scanner/scan'].

Any idea what could cause this?

[hidmic]

@XavierTrudeau a backtrace would surely help.