Coder Social home page Coder Social logo

Comments (2)

mintar avatar mintar commented on July 29, 2024

Thanks to @jspricke I think I know what the problem was. The patch includes some CRLF line endings in dataadapterdevice.c (which is the file where patching fails). These are correctly preserved in this repo. However, I have set core.autocrlf = input in my global .gitconfig on my PC. So when I ran bloom-release here, bloom took my .gitconfig into account when committing stuff to the GBP repo, thereby messing up the line endings (and replacing them all with LF). So bloom caused the patch file in the GBP repo to be different from the patch in the source repo here.

This is also why the prerelease test didn't fail: I ran it on "devel", i.e. this repo, and not on the released version from the messed-up GBP repo.

The solution should be to disable core.autocrlf in the global .gitconfig and do a new bloom release. I'll close this ticket once I can confirm that this fixes the bug.

from phidgets_drivers.

mintar avatar mintar commented on July 29, 2024

Should be fixed by ros/rosdistro#25324. Let's wait and see.

from phidgets_drivers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.