fatal error when one of the symbols returns only one row about yfr

[msperlin]

Hi Renan,

The idea is for the user to have more care regarding which tickers are being inputed. Since there isn't much you can do with a one row dataframe, perhaps you should remove DNAI11 from the requested ticker vector?

[rvalieris]

yes, I agree this ticker is problematic, I don't know why but yahoo finance sometimes it returns more data and sometimes no data for this ticker.

however my script was already dealing with the missing data, and for some use cases just having the latest price is already useful so if possible I would like it return whatever data it got even if its just a single row. otherwise I can split the call in two parts, but I will need to change my script to keep track of which tickers are problematic.

[msperlin]

I can see your reasoning, and I agree with it. I'll make it a warning (and not an error). This will make sure the rest of the data is returned.

I'll leave this issue open and make the changes next week.

[rvalieris]

thanks, to be clear, I think the default behavior as it works now is good and useful but, as I understand, if I set the option thresh_bad_data=0 I expected to get whatever data was returned even if its all missing at least thats how I understood BatchGetSymbols works.

[msperlin]

Ok, fixed. Try it out:

remotes::install_github("ropensci/yfR")

[rvalieris]

works great. thanks !

Fetching data for DNAI11.SA
! 	- not cached
✔ 	- got 1 valid rows (2022-12-06 --> 2022-12-06)
✔ 	- got 2% of valid prices -- Feliz que nem lambari de sanga!