Comments (5)
I propose to close this issue as clarified: I agree that the solution is to make backporting as easy as possible (#14889) to avoid these cases. We can focus our attention to the automation.
from root.
Are there some common guidelines for the future on this? Like 'only do changes in 6.30 branch', or 'only do changes in master and then backport'?
I don't think we have a guideline yet for this very specific case. I think in practice, for the majority of cases we try to merge changes in master and then backport.
from root.
Are there some common guidelines for the future on this? Like 'only do changes in 6.30 branch', or 'only do changes in master and then backport'?
I don't think we have a guideline yet for this very specific case. I think in practice, for the majority of cases we try to merge changes in master and then backport.
Let's imagine an example. I fix an issue for 6.32, and it is automatically collected and added to the 6.32 Release Notes. Furthermore i add a custom message to 6.32relnotes in the e.g. roofit section. I then backport the fix to 6.30. However, this time, the custom message in relnotes will not be automatically added to the 6.30 Release Notes because it was already released. So, after backporting the fix from master to 630, should one:
a) Create a new PR for the 630_ReleaseNotes file, but on the master branch and then after merging, backport it to 6.30 branch
or
b) Create a new PR for the 630_ReleaseNotes file and forget about the master branch, which will stay with an outdated version of 630-relnotes, which is however not very critical since the RelnotesWebpage for 6.30 is built from the 630 branch and not from master?
from root.
it will not be automatically added to the 6.30 Release Notes because it was already released
This might not be specific enough. The release notes for the already released version of v6.30 (let's say v6.30.04) are frozen by definition. However the fix should be properly pickup by the release procedure for the next version, i.e. v6.30.06. (of course this require adding the proper tag to the issue). What am I missing?
from root.
it will not be automatically added to the 6.30 Release Notes because it was already released
This might not be specific enough. The release notes for the already released version of v6.30 (let's say v6.30.04) are frozen by definition. However the fix should be properly pickup by the release procedure for the next version, i.e. v6.30.06. (of course this require adding the proper tag to the issue). What am I missing?
Thanks for the message.
True, but I did not express myself well (edited now above message). I am not speaking only about the automatic fixed issues collection protocol. I am speaking about manual additions to the release notes where a more in-depth message is written. In that case, there is the ambiguity of where this should be added, in the 63006relnotes of master and then backport to 630patches, or rather directly in 630patches. Right now, we have a bit of everything. If you use 'meld' to compare them, you will see the issue more clearly.
from root.
Related Issues (20)
- Enable additional LLVM checks
- CMakeLists.txt CMAKE_BINARY_DIR not working correctly HOT 2
- Performance regression (slowdown) in ALICE event generation HOT 1
- Compilation issues with gcc 14.1.1, C++20, ROOT v6.30.06 HOT 7
- Infinite recursion in TFile::Open
- Memory leak in TTree __getattr__ pythonization HOT 1
- New CI label for nightly does not correctly report cmake configuration HOT 1
- `RDF::Describe` returns an incorrect file count
- Buffer overflow in TBranch::Init
- [RDF] Some tutorials fail to run when compiled due to jitting issues
- [io] Properly handle failures in custom streamers
- TGFileContainer crashes in pyroot HOT 3
- [ntuple] Cannot properly read late model extension (meta)data
- [ntuple][doc] document RNTuple Anchor format HOT 1
- JITted code changes the execution order of computation graph nodes
- [PyROOT] TProfile2D::Fill ambiguities preventing use of some signatures in pyROOT HOT 2
- [RF] SegFault in RooBernstein::fillBuffer HOT 1
- [RF] New RooFit EvalBackend returning incorrect result for binned likelihoods
- [RF] New RooFit EvalBackend cannot handle models with categorical parameters (crashes)
- Leaking memory though strings in PyROOT
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from root.