Openoffice files can not be open about roo

[pabloh]

Does it work fine at Roo 1.10.1?

2013/2/3 Jakub Tesinsky [email protected]

When i try to read files from test/files directory like so:

require 'roo'
puts Roo::Spreadsheet.open('Bibelbund.xls').inspect
puts Roo::Spreadsheet.open('Bibelbund.ods').inspect

I get at error at trird line. xls file is read normally, reading and
inspecting ods file gives this error:

/var/lib/gems/1.9.1/gems/roo-1.10.2/lib/roo/generic_spreadsheet.rb:703:in validate_sheet!': Error: sheet 'nil' not valid (ArgumentError) from /var/lib/gems/1.9.1/gems/roo-1.10.2/lib/roo/openoffice.rb:327:inread_cells'
from /var/lib/gems/1.9.1/gems/roo-1.10.2/lib/roo/openoffice.rb:203:in to_s' from manip.rb:14:ininspect'
from manip.rb:14:in `

'

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/12.

[Kagetsuki]

I tested this and can confirm:

ruby-1.9.3-p362/gems/roo-1.10.2/lib/roo/generic_spreadsheet.rb:703:in `validate_sheet!': Error: sheet 'nil' not valid (ArgumentError)
    from /home/zero/.rvm/gems/ruby-1.9.3-p362/gems/roo-1.10.2/lib/roo/openoffice.rb:327:in `read_cells'
    from /home/zero/.rvm/gems/ruby-1.9.3-p362/gems/roo-1.10.2/lib/roo/openoffice.rb:203:in `to_s'
    from rootest.rb:3:in `inspect'
    from rootest.rb:3:in `<main>'

This occurs on inspect. I removed the inspect and just tried to read a cell and got:

ruby-1.9.3-p362/gems/roo-1.10.2/lib/roo/generic_spreadsheet.rb:703:in `validate_sheet!': Error: sheet 'nil' not valid (ArgumentError)
    from /home/zero/.rvm/gems/ruby-1.9.3-p362/gems/roo-1.10.2/lib/roo/openoffice.rb:327:in `read_cells'
    from /home/zero/.rvm/gems/ruby-1.9.3-p362/gems/roo-1.10.2/lib/roo/openoffice.rb:87:in `cell'
    from rootest.rb:3:in `<main>'

So I tried explicitly selecting the first sheet and get the same validate sheet error. XLS version of the same file works fine.

[Empact]

Could you check whether this problem still exists in v1.11.0, which was just released?

[Kagetsuki]

Just tested 1.11.0 in ruby 2.0.0p0 - everything looks fine in my test but as I recall it was a few specific sheets that gave me issues. The sheet I tested I -think- was one of those, but I may be mistaken. Consider the issue solved and close it I say.

Thanks for the improvements Empact. Roo is fantastic. Right now I'm working on a converter to output in xls and ods, including the option to use template spreadsheets. I'll give you a heads up when I release it?

[Kagetsuki]

@Empact I think this should be closed as it is fixed.