commonjs + inject about plugins

[shellscape]

@drzraf I'm afraid you'll have to distill this issue a bit further before we can triage it. Please identify what isn't working within @rollup/plugin-inject, or rollup-plugin-commonjs. Once you have it narrowed down, we'll be able to help you further.

[shellscape]

@drzraf please see the previous reply. If that's something you're willing to tackle, we'll be happy to reopen this issue.

[drzraf]

I can't go further than what I already provided. Sorry to see such a high entry bar to bugfixes

[shellscape]

Everyone here volunteers their time to work on the project. When users come here with issues that involve complex configurations or reproductions, we ask that they distill the config or repro down to a simple form that highlights the issue faced. We simply don't have the time or resources to deep dive nuanced configs. That's why we ask for minimal reproductions in the issue template.

I'm sorry that you can't reduce your reproduction further, and that you feel that triage is creating a high entry bar. Perhaps someone else who can will pick this up in the future.

[Andarist]

@shellscape i take a quick look at provided repro and it seems to be pretty minimal

[shellscape]

@Andarist We've asked for the conflict between the two plugins to be distilled further in an earlier reply.

[Andarist]

I think the root cause here is quite simple - I've stumbled upon a really similar issue lately while debugging it.

Problem is that @rollup/plugin-inject injects import statements, so it makes automatically a module out of the given file, even if it's just a script - like in your case because your files are written using commonjs. And this makes rollup-plugin-commonjs to think that what it receives is already a module and it skips transforming it altogether, so it just leaves your module.exports and such intact.

In this particular case, you can reorder your plugins - put rollup-plugin-commonjs before @rollup/plugin-inject so a commonjs plugin can make its magic first and transform your scripts to modules.

[drzraf]

Thank you for the proposed workaround @Andarist.
It resolves the problem in the context of this repro (In my real codebase I remember having hit another issue when changing plugin order. I'll let you know here if I hit it again)

I updated repository's testcase in the meantime.

[walmon]

I'm also experiencing it. Hopefully it can be addressed.