Coder Social home page Coder Social logo

Comments (2)

r-park avatar r-park commented on August 17, 2024

Hi, the following change seems to resolve the item rendering issue:

// common/shadow_dom.ts

export const shadowDomInjectables: Array<any> = !isNativeShadowDOMSupported ? [] : [
  //bind(ShadowDomStrategy).toClass(NativeShadowDomStrategy)
  NativeShadowDomStrategy
];

And this change resolved a related issue caused by this.el.shadowRoot being null:

// app/components/icon/icon.ts

set src(src: string) {
  //let root;
  //if (isNativeShadowDOMSupported) root = this.el.shadowRoot;
  //else root = this.el;
  this.icon.get(src).then((svg) => {
    //root.appendChild(svg);
    this.el.appendChild(svg);
  });
}

from angular-lab.

rolandjitsu avatar rolandjitsu commented on August 17, 2024

@r-park that doesn't really solve the issue. It just doesn't use NativeShadowDomStrategy anymore which makes the icons work again, but that is not really what I am looking for.

I would still like to have Shadow DOM used if supported and the icons work properly no matter if Shadow DOM is used or not.

I will have to take a look into it, but I also reported it as #3222 and hopefully I will get some insight on what is going on.

from angular-lab.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.