Coder Social home page Coder Social logo

Comments (6)

JulianStiebler avatar JulianStiebler commented on August 18, 2024

The name is in "All Forms" - it is intended to produce all genders aswell. The game just accepts it, so figured why not - if you dont like that you can either set the code to generate values for the caughtAttr lowered by the bit amount of Male/Female needed;

class DexAttr(Enum):
    NON_SHINY = 1
    SHINY = 2
    MALE = 4
    FEMALE = 8
    VARIANT_1 = 16
    VARIANT_2 = 32
    VARIANT_3 = 64
    DEFAULT_FORM = 128

If it bothers you:
-> Either edit every caughtAttr relevant in your trainer.json manually to be shifted by 4 or 8 down depending on what gender
The caughtAttr is set together based on all before going variables, meaning a female+male pokemon has both 4+8 included. Reducing it by 4 or 8 respectively should remove either gender of its possibilities.

If you want a feature seen that alleviates this automatically:
-> Feel free to edit the hasForms.json for me so it indicated also the Gender Status;
or simply list here what pokemond should be prefixed to which gender specifically;

For example: Lets assume Gender = 0 means it can have both, gender=1 male, gender=2 female

Cresselia Gender 2
Rayquaza Gender 1
etc

from pyrogue.

Kishuna avatar Kishuna commented on August 18, 2024

Thank you for clarifying. I suspected this might be the case, but I wasn't entirely sure, so I listed it as a bug. This issue does bother me personally, but with this information, I can make the necessary adjustments for my own use.

I would be more than happy to list each Pokemon, but I would have to look into it. Please leave this open and expect an update in the next day or so.

Thank you again!

from pyrogue.

JulianStiebler avatar JulianStiebler commented on August 18, 2024

Alrighty, thank you very much. Once i have the appropiate data i will implement it to also ask to unlock all genders, if set to None i will try to setup the caughtAttr's to take genders in account related to each ID.

A simple list as mentioned is already enough to work with;

Gender 0 = Can have both (All that are not listed kinda)
Gender 1 = Male Only
Gender 2 = Female Only

Just need to list the ones that are specific;

Cresselia - Gender 2
Rayquaza - Gender 1

As the lst above is best; Im currently merging multiple .json together:
For example hasForms, species, starters could all be done in one, also making code readablity and usability easier.

from pyrogue.

Kishuna avatar Kishuna commented on August 18, 2024

As promised, please see here. There are a lot of gender-specific species, so I had to put it into a Sheet.

A few things to note:

  • Only Starters are listed for relevancy purposes. I noticed there is a caughtAttr for ALL Pokemon, but do note there are many intricacies with evolutions (i.e. Battle Bond Greninja is always male).
  • Genderless Pokemon have a value of -1 in slot_#.json files, indicating they truly have no gender data. I can confirm through my own fixes to my save file their "legal" value is offset by -12. Therefore, they are listed in the sheet with a value of -1.
  • There are some alternate form intricacies that were ultimately omitted from PokeRogue entirely (i.e. Bloodmoon Ursaluna is technically male only, but both genders can be obtained in PokeRogue). As the purpose is to emulate "legal" data, these have been omitted from my sheet.

Please let me know if there is anything else I can do to help.

from pyrogue.

JulianStiebler avatar JulianStiebler commented on August 18, 2024

Oh time flew by, no new issues popped up and i forgot to look.
How they are entried in slot_.json doesnt really matter for our purpose, if the caughtAttr is correct setly it will start the game anyway with the correct data into slot_.json.

I'll add the genders and also some other cool stuff in a upcoming update - but it might take a while

(Sneek Peek)
{

    "dexData": {
        "1": {
            "name": "Bulbasaur",
            "isStarter": true,
            "hasPassive": true,
            "hasForms": null,
            "gender": 0,
            "group": 0,
            "type": [
                11,
                3
            ]
        },

I also added types to all forms, and some more data i won't display here yet, so it's getting deep 🗡️

from pyrogue.

JulianStiebler avatar JulianStiebler commented on August 18, 2024

Oh i forgot to close; gonna take a while for next update.

from pyrogue.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.