Comments (4)
I think Solution 1 would make the most sense, having separate advanced parameters for peakPickerMRM (admittedly, some of the parameters are hard coded/set for known working chromatograms settings). This way, if the user selects no smoothing for the visualization aspect, they can still do peak picking on the raw data, and play with peak picking smoothing.
If the user does apply smoothing for visualization, then should both visualization and peak picking smoothing always be the same, or independent?
from massdash.
Also, right now sgolay_polynomial_order
and sgolay_frame_length
get returned from chromatogram_plotting_settings, which is also already in smoothing_dict
which also gets returned. I think I will refactor only return and pass smoothing_dict
to make it easier to add other smoothing functions. I don't know why I have this redundancy lol
from massdash.
Hmm would that be confusing though to have the peak picking boundaries on the chromatogram not shown? Having said that it is useful for new algorithm development. Maybe there can be a checkbox that will just do peak picking on the shown chromatogram and if that is unchecked then the advanced parameters are shown?
from massdash.
Addressed with PR #6
from massdash.
Related Issues (20)
- [BUG] Unexpected keyword argument for conformer peak picking
- Streamlit Caching sometimes too good HOT 1
- Spectra seem to have overlapping signals HOT 2
- [BUG] Conformer Peak Picking Incorrect Dimensions
- [BUG] MRMTransitionGroupPicker does not work with "none"
- Update Tests for better pandas df snapshots HOT 3
- Display Features in mobilogram
- BUG: Windows bioconda install
- Readme python versions incorrect HOT 2
- BUG (GUI): Raw Extraction Workflow Missing streamlit session key
- [ADD] Bioconda install HOT 1
- [ADD] server port argument to gui command
- [REFACTOR] Targeted Extraction with pyOpenMS
- Picking on displayed chromatogram
- SQLite objected created in a thread can only be used in that same thread HOT 1
- [BUG] 2D plotting for DIA equalization HOT 1
- [BUG] Search Results Load Example Data
- [BUG] Conformer model not in Raw targeted extraction workflow
- [FEATURE] adjust peak boundary height intensities
- CI/CD Tests
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from massdash.