Warning when space-time coordinates specified are not covered in the weather file used. about rocketpy

[giovaniceotto]

For latitude and longitude, currently a TypeError is thrown if the input values are outside the grid given by netCDF and OPeNDAP files.

The current idea is to keep throwing errors for such cases since bi-linear interpolation is no longer possible outside the grid given. However, the type of the exception should be different, perhaps ValueError.

In case of the date input, the current implementation does not interpolate between dates in the file, but simply chooses the closest one, i.e. nearest neighbor. Therefore, an exception is not necessary and just a warning would be fine.

[giovaniceotto]

I believe raising a ValueError for wrong date inputs would be better than using warning, specially in terms of consistency. Besides consistency, I do not believe there is a big different for the end user.

[giovaniceotto]

Just fixed this in the last two commits: a97620f and e99389e.

When the input longitude, latitude and date are outside the range supplied by the file, a ValueError exception is thrown, explaining the reason and showing the relevant range of the file.

An alternative for the date would be simply to ask netCDF4 to select only exact dates, raising and error whenever a date supplied not contained in the file was given. This wasn't the chosen implementation since it offered little explanation to the user.

Furthermore, when the input date does not match exactly any of the file dates, a warning is now given, and the nearest date available is used. This was decided since no date interpolation is done. Of course, this does not apply to dates outside the file range.