BUG: can't read some .eng files about rocketpy

[luimot]

I think this is because in SolidMotor.py the line in the method importEng()

if line[0] == ";":

is only checking the first character in each line of the .eng file and the last ";" in the file is one tab ahead and breaks this logic, I tested the code block below using simple regex and it seems to resolve it even when ";" is commenting anywhere else in the doc if it's not before any relevant data, like a normal comment line

if re.search(r";.*", line):
    # Extract comment
    comments.append(re.findall(r";.*", line))
    line = re.sub(r";.*", "", line)
if not line.isspace():
    if description == []:
        # Extract description
        description = line.strip().split(" ")
    else:
        # Extract thrust curve data points
        time, thrust = re.findall(r"[-+]?\d*\.\d+|[-+]?\d+", line)
        dataPoints.append([float(time), float(thrust)])

[giovaniceotto]

@Projeto-Jupiter/back-end

[Gui-FernandesBR]

I still have my questions regarding the nature of that extra ";"
Is it that common or was it just 1 simple mistake?

Anyway, I think @luimot 's addition is going to help with the current bug so that's what matters for now.

@luimot would you mind openning a PR with this implementation?

[giovaniceotto]

    comments.append(re.findall(r";.*", line))
    line = re.sub(r";.*", "", line)
if not line.isspace():
    if description == []:
        # Extract description
        description = line.strip().split(" ")
    else:
        # Extract thrust curve data points
        time, thrust = re.findall(r"[-+]?\d*\.\d+|[-+]?\d+", line)
        dataPoints.append([float(time), float(thrust)])

Seems like a perfect implementation to me @luimot. Takes care of comments which are preceded by space or any other character.

Out of curiosity, is using regex in this case faster than just removing trailing whitespace (left and right) and splitting each line by the ;?

[giovaniceotto]

I still have my questions regarding the nature of that extra ";" Is it that common or was it just 1 simple mistake?

Anyway, I think @luimot 's addition is going to help with the current bug so that's what matters for now.

@luimot would you mind openning a PR with this implementation?

This extra ; is allowed by the specification. More details here: RASP format.

[luimot]

@giovaniceotto I don't know what could be faster, I think maybe because both are simple operations in their own way it wouldn't be a significant change but wouldn't be surprised if it were faster, regex has a bit cumbersome syntax but it's an awesome tool.

[giovaniceotto]

Issue fixed in the develop branch by #105