Handle getWsUrl failiure simmilar to WS failiures about react-use-websocket

[robtaussig]

Ahh, great point! I will implement for next release, or happy to accept a pull request if you need it sooner.

[robtaussig]

Had a moment to check in on this, and my reading of it is that this should already be the behavior. The reconnect function calls the same function used to get the url in the start phase, which means that it should refetch the url in the retryInterval:

const start = async () => {
  convertedUrl.current = await getUrl(url, optionsCache); //Fetches/refetches url here

  const protectedSetLastMessage = (message: WebSocketEventMap['message']) => {
    if (!expectClose) {
      setLastMessage(message);
    }
  };

  const protectedSetReadyState = (state: ReadyState) => {
    if (!expectClose) {
      setReadyState(prev => ({
        ...prev,
        ...(convertedUrl.current && {[convertedUrl.current]: state}),
      }));
    }
  };

  removeListeners = createOrJoinSocket(
    webSocketRef,
    convertedUrl.current,
    protectedSetReadyState,
    optionsCache,
    protectedSetLastMessage,
    startRef, // Function called for reconnect
    reconnectCount,
  );
};

//Reconnect by removingPrevious listeners and then calls start function
startRef.current = () => {
  if (!expectClose) {
    if (webSocketProxy.current) webSocketProxy.current = null;
    removeListeners?.();
    start();
  }
};

start();

Are you seeing different behavior? If so, do you have any thoughts on how to change above logic?

[jaecktec]

maybe we should add some tests 🙈
I noticed this behaviour when having a service that was restarting after a change.
From the code I think there should be a try/catch around the getUrl part.. however I have not checked the internas of this library to see what happens.

[robtaussig]

Tests are never a bad idea. Will close for now and start working on some tests when time frees up. Feel free to re-open if the problem persists.

[stanleyk]

The problem actually persists. Any time the getUrl async call throws, no reconnect attempts are made. The throw bubbles up and that's it.