Race condition causing elements to return incorrect values after connecting about virtualgamecontroller

[robreuss]

It looks like you are sending the avatar and string immediately (after 1 sec delay) calling VgcManager.peripheral.connectToService.

Instead it would be better if you wait and send those after you receive the VgcPeripheralDidConnectNotification notification.

Let me know if that works!

[robreuss]

Ignore that last comment - you are in fact handling it correctly. Looking now for other causes!

[robreuss]

I think I got this figured out. When defining your valueChangedHandler for image and name, you were using the same var controller internal to the block as you were in assigning the handler. If the var internal to the handler block has a different name, thing seem to work properly:

        // Avatar Image
        controller.elements.custom[CQVGCCustomElementType.ProfileAvatarImage.rawValue]!.valueChangedHandler = { (con , element) in

            dispatch_async(dispatch_get_main_queue()) {

                if let playerView = self.playerToView[con] {
                    playerView.avatarImageView.image = UIImage(data: element.value as! NSData)
                    self.playerToAvatar[con] = UIImage(data: element.value as! NSData)
                }
            }
        }

I do the same thing in my samples so it's understandable that you did it!

[robreuss]

Unfortunately, that was not the fix - I started seeing the duplicate avatars again. By switching to the standard "image" element, I was able to fix the problem, and so zeroed in on a problem with how custom elements were copied. I've fixed that and pushed the changes, so if you pull master, it should be working correctly now!

[ay8s]

That looks to be working correctly now @robreuss 👍