Coder Social home page Coder Social logo

Comments (8)

Nicogene avatar Nicogene commented on September 28, 2024 2

Today @traversaro and I discovered that after #482 all the robots that use embObjStrain have the publishing of the FT broken because embObjStrain has not been ported to IMultipleAnalogSensorsInterfaces (see https://github.com/robotology/icub-main/blob/001b897fb29aaa1cb58ff713361fc68b2f97e1ca/src/libraries/icubmod/embObjStrain/embObjStrain.h#L52-L55)

Same thing for the robots that uses canBusAnalogSensor (see https://github.com/robotology/icub-main/blob/001b897fb29aaa1cb58ff713361fc68b2f97e1ca/src/libraries/icubmod/canBusAnalogSensor/CanBusAnalogSensor.h#L42)

This is not caught by the CI because right now multipleanalogsensorsserver does not fail if the device attached does not implement any interface (see https://github.com/robotology/yarp/blob/872679fa605b95163da4a64e61c161ab9df3d485/src/devices/multipleanalogsensorsserver/MultipleAnalogSensorsServer.cpp#L403-L413)
In this sense, we can add that if all view fail we throw an error but this will not solve the problem will only make the ci fail for the robots we broke.

We spoke w/ @marcoaccame and we checked that right now both embObjFTSensor and embObjMultipleFTSensor (the ones compatible w/ MAS pipeline) does not support right now strain board.
We would need a change embobjFTSensor in icub-main for ignoring the temperature/imu sensor when using strain, on fw side we do not need anything. In this way, we could throw away embObjStrain since it is used only w/ analogServer.
Moreover, we need to migrate the xml files of strain to the "new" device.

The last resort is to roll back the robot that is now broken to analogServer but it would be a pity.

cc @pattacini @valegagge

from robots-configuration.

pattacini avatar pattacini commented on September 28, 2024 2

Thanks for the summary 👍🏻

We will be discussing this the next Tue at the board meeting.

from robots-configuration.

Nicogene avatar Nicogene commented on September 28, 2024 1

The PR #505 has been merged, I will then proceed to apply those changes to all the robots.

cc @pattacini @traversaro

from robots-configuration.

Nicogene avatar Nicogene commented on September 28, 2024 1

PR: #517

I will test it on iCubGenova11 tomorrow. I am not sure it will be cover all the cases, I hope the dry-run will help in this sense

from robots-configuration.

Nicogene avatar Nicogene commented on September 28, 2024 1

Putting on hold since we need to takle this: robotology/icub-main#873

from robots-configuration.

pattacini avatar pattacini commented on September 28, 2024 1

Putting on hold since we need to takle this: robotology/icub-main#873

Done!

from robots-configuration.

Nicogene avatar Nicogene commented on September 28, 2024 1

We can finally close this issue, we will track the work on the simulators on a different one.

from robots-configuration.

pattacini avatar pattacini commented on September 28, 2024

I am not sure it will be cover all the cases, I hope the dry-run will help in this sense

🤞🏻

from robots-configuration.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.