Coder Social home page Coder Social logo

Comments (8)

S-Dafarra avatar S-Dafarra commented on June 12, 2024 2

In any case, I think that it does not make sense to require the constraint matrix to be set if there are no constraints. If something else breaks, we shall fix it as well 😁

Could you add the unconstrained problem as a test case?

from osqp-eigen.

GiulioRomualdi avatar GiulioRomualdi commented on June 12, 2024 2

Related issue osqp/osqp#295

from osqp-eigen.

S-Dafarra avatar S-Dafarra commented on June 12, 2024

Just to understand, what is the output if you add no constraints at all?

from osqp-eigen.

GiulioRomualdi avatar GiulioRomualdi commented on June 12, 2024

Just to understand, what is the output if you add no constraints at all?

[OsqpEigen::Solver::initSolver] Some data are not set.

from osqp-eigen.

S-Dafarra avatar S-Dafarra commented on June 12, 2024

Ok this sounds like a logical problem then. That should be easy to solve then.

osqp-eigen/src/Data.cpp

Lines 88 to 97 in 9b00910

bool OsqpEigen::Data::isSet() const
{
return m_isNumberOfVariablesSet &&
m_isNumberOfConstraintsSet &&
m_isHessianMatrixSet &&
m_isGradientSet &&
m_isLinearConstraintsMatrixSet &&
m_isLowerBoundSet &&
m_isUpperBoundSet;
}

should become

    return m_isNumberOfVariablesSet &&
        m_isNumberOfConstraintsSet &&
        m_isHessianMatrixSet &&
        m_isGradientSet &&
        (m_data->m ==0 || m_isLinearConstraintsMatrixSet ) &&
        m_isLowerBoundSet &&
        m_isUpperBoundSet;

right?

from osqp-eigen.

GiulioRomualdi avatar GiulioRomualdi commented on June 12, 2024

I don't know if it's so simple (We should investigate the side effects)

from osqp-eigen.

GiulioRomualdi avatar GiulioRomualdi commented on June 12, 2024

I think that it does not make sense to require the constraint matrix to be set if there are no constraints

I agree

from osqp-eigen.

S-Dafarra avatar S-Dafarra commented on June 12, 2024

Related issue oxfordcontrol/osqp#295

Ah, nice! So if it is also a limitation of osqp, the solution you proposed in the OP seems the way to go then.

from osqp-eigen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.