Coder Social home page Coder Social logo

Comments (16)

mumoshu avatar mumoshu commented on August 23, 2024 1

@sstarcher Thx for the response!

How about just improving helmfile sync to also run helm dep update when the release's chart: references a local chart?

I'm curious about the usefulness of only running dep update or even repo update(already implemented as helmfile repos but I have never got to use that myself) through helmfile.

from helmfile.

fsilberstein avatar fsilberstein commented on August 23, 2024 1

@mumoshu Exactly, we apply args too early, I just inverted the lines of code, that's all. My PR is ready for your review :) Thank you

from helmfile.

mxey avatar mxey commented on August 23, 2024 1

Yeah, I actually just realized charts is probably better for me. Although I still think it would be sensible to have separate commands, like sync and update.

from helmfile.

mumoshu avatar mumoshu commented on August 23, 2024 1

From the discussion made in #415, I'm considering to add helmfile dependency update(#450), as well as changing helmfile to run dependency buidl rather than dependency update in helmfile sync, diff, apply and template.

Does that make sense to you?

from helmfile.

mumoshu avatar mumoshu commented on August 23, 2024

@xeor Sounds reasonable!

But out of curiosity, would you mind sharing me how do you separate uses between helm and helmfile when you are able to use the helm's umbrella chart pattern like you do?

Can't you just transform your helmfile into a single umbrella helm chart so that perhaps you can just use helm status against it?

from helmfile.

xeor avatar xeor commented on August 23, 2024

This was only for my personal charts.. The umbrella is not that big, but I got multiple "umbrellacharts".
I don't really like to put all the variables inside the helmfile. The helmfile for me is more or less a collection of charts. If it's an upstream chart, and it got just a couple of values to change. I might put the values in the helmfile. Otherwise, I like not to..

from helmfile.

mumoshu avatar mumoshu commented on August 23, 2024

@xeor Thanks for the clarification!

I've iterated on your explanation and my current/possible use-cases of helmfile.
And now I believe your use-case is ABSOLUTELY valid!

Would it be good for you if helmfile sync just runs helm dependency update before updating the releases? Would there be any bad side-effect of doing so?

from helmfile.

mumoshu avatar mumoshu commented on August 23, 2024

cc/ @sstarcher Would you also be happy with this change?

from helmfile.

mumoshu avatar mumoshu commented on August 23, 2024

@xeor FWIW, I also believe a small enhancement to helmfile like #28(which would also support #49) would allow helmfile to support what we can't easily do with umbrella charts. Appreciate your comments on those two issues, too!

from helmfile.

sstarcher avatar sstarcher commented on August 23, 2024

I could see this being useful for local file paths. It should detect it's going against a local filepath and run dep update.

from helmfile.

cmeury avatar cmeury commented on August 23, 2024

@xeor Would you mind giving this a test run?

from helmfile.

fsilberstein avatar fsilberstein commented on August 23, 2024

This merged is working but it's bringing a new issue. Previously, when you wanted to wait for the readiness of your pods, you just had to pass args flag with "--wait".
Now this args flags are also passed to the update dependencies command.I can do a PR to fix it if needed.

from helmfile.

mumoshu avatar mumoshu commented on August 23, 2024

@fsilberstein Thanks for the good catch! Ah, so we seem to set helm extra args too early?. A PR would be much appreciated anyway.

from helmfile.

mumoshu avatar mumoshu commented on August 23, 2024

Closing this as resolved via #85. Thanks for the PR @fsilberstein!

from helmfile.

mxey avatar mxey commented on August 23, 2024

I just run into this accidentally, when my helmfile sync failed. I see two problems with this feature:

  • helm dependency update fails if the chart has no requirements.yaml
  • Doing this implicitly as part of the sync command breaks the declarative nature of Helmfile and umbrella charts for me. I want to control the requirements.lock and decide when I update the charts I use. I think this is bad surprise from what people expect from the “sync” command because it should just apply the local state to the cluster, not change the local state. If you run Helmfile in CI, like I do, the changed requirements.lock files won't even be saved.

from helmfile.

cmeury avatar cmeury commented on August 23, 2024

If you only want to upgrade --install, you could you just run the charts command? I understand sync as some sort of "all in one" step.

from helmfile.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.