Comments (2)
Thanks for the explanation. I added package
to the ssl_gc protobufs and that works in our repo. For C++, package
gets compiled into namespaces, so enums aren't a problem at all. For example, assuming package SSL;
, the C++ type for the Team
protobuf message would be SSL::Team
. That fixes my problem, so closing this issue
from ssl-game-controller.
I removed the SSL_ prefix intentionally, because it is not a valid name according to the protobuf naming convention: https://developers.google.com/protocol-buffers/docs/style#message_and_field_names
If you do not want to refactor your code, you can just rename the field in your codebase. The message and field names are not part of the API.
Name conflicts can easily be solved using packages, as the GC does with go_package
and for example the TIGERs AutoRef does with package
: https://github.com/TIGERs-Mannheim/AutoReferee/blob/master/modules/moduli-referee/src/main/proto/ssl_gc_referee_message.proto#L3
One difficulty are enums indeed. They must be unique outside packages as well. I think that's why the Team
is in a common package. Is this an issue in your code base as well? And if so, can't you reuse the Team and/or RobotId?
from ssl-game-controller.
Related Issues (17)
- The game controller crashes without internet connection HOT 2
- When ball placement fails, it is not always clear why HOT 1
- Feature: Add a filter option for the protocol HOT 1
- Aborting a placement with a force start causes side effects HOT 3
- Bug: Wrong placement position (goal instead of corner kick?) for excessive bot substitution
- Unset GameEvent type in referee message HOT 2
- Bug: Ball placement pos on wrong side after failed penalty
- Penalty shootout: Do not set next action to free kick after failed kick
- Add buttons to switch team that last touched ball before ball went out
- Add an easier way to add manual game events like dropped parts
- UI: Show team names together with blue/yellow when creating new game events
- Unit documentation in GameEvent HOT 4
- Dependency Dashboard
- Entering numbers on numpad triggers commands
- Merge "Direct" and "Indirect" free kick buttons HOT 1
- error occured in release binary at v3.0.0 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ssl-game-controller.