Net v2.0.0 about rbx-net

[Vorlias]

With v2, I'm contemplating fully removing function objects in favour of the async functions (RemoteEvent driven functions). Much friendlier for tools like NoahWillCode's event log, and also actually supports using async callbacks and calling clients.

[Vorlias]

The middleware in RbxNet is typed similarly to Rodux now.

e.g. converting an "id" to an NPC

const toNPC: Middleware<[NPCEntity], [string]> = (next) => {
    return (sender, npcId) => {
        const npc = NPCManager.GetNPCById(npcId);
        if (npc) {
            next(sender, npc); // this will pass the NPC as an argument
        }
        // If `next` is never called, it will silently fail. I'm considering a sort of "reject" function as well.
    }
};

const TradeWithNPC = new Net.ServerEvent("TradeWithNPC", [Net.Typed(t.string), toNPC]);
TradeWithNPC.Connect((player, npc) => {
    // npc is of type NPCEntity
});

[Vorlias]

I'm considering now moving the connect-related middleware to the connect function itself. Probably a more sensible option. :?

[iamacup]

Hey

A couple of points on the state of 2.x - It looks great!

• The majority of the code seems to need to be wrapped with /* eslint-disable roblox-ts/no-any */ to stop fatal linting errors (for default rules from roblox-ts) - i assume this is because the types are not finalised yet? i might be able to help if thats the case.
• It looks like git is out of sync with NPM and/or the docs are versioned wrong - 2.0.0.alpha.7 is the latest version on master at git but NPM has 2.0.0.alpha.6

I submited a docs-only pull request to fix up some errors in the 2.x docs as well :)

great work!

[Vorlias]

Hey

A couple of points on the state of 2.x - It looks great!

* The majority of the code seems to need to be wrapped with `/* eslint-disable roblox-ts/no-any */` to stop fatal linting errors (for default rules from roblox-ts) - i assume this is because the types are not finalised yet? i might be able to help if thats the case.

* It looks like git is out of sync with NPM and/or the docs are versioned wrong - `2.0.0.alpha.7` is the latest version on master at git but NPM has `2.0.0.alpha.6`

I submited a docs-only pull request to fix up some errors in the 2.x docs as well :)

great work!

Haven't run into any linting issues with the roblox-ts linter, although it is a bit buggy and usually vscode requires a restart if that happens.

The NPM version should be updated to 2.0.0-rc.0 in a moment. This should be a more akin to what the release will look like. (which includes changes from .7)