Comments (1)
Maybe something along these lines ...
[new]
const tingleCloseNone = 0;
const tingleCloseKeyboard = 1;
const tingleCloseButton = 2;
const tingleCloseClickOutside = 3;
var _reasonForClose = tingleCloseNone;
Modal.prototype.reasonForClose = function () {
return this._reasonForClose;
}
[modify]
function _handleKeyboardNav (event) {
// escape key
if (this.opts.closeMethods.indexOf('escape') !== -1 && event.which === 27 && this.isOpen()) {
this._reasonForClose = tingleCloseKeyboard;/*new*/
this.close()
}
}
function _handleClickOutside (event) {
// on macOS, click on scrollbar (hidden mode) will trigger close event so we need to bypass this behavior by detecting scrollbar mode
var scrollbarWidth = this.modal.offsetWidth - this.modal.clientWidth
var clickedOnScrollbar = event.clientX >= this.modal.offsetWidth - 15 // 15px is macOS scrollbar default width
var isScrollable = this.modal.scrollHeight !== this.modal.offsetHeight
if (navigator.platform === 'MacIntel' && scrollbarWidth === 0 && clickedOnScrollbar && isScrollable) {
return
}
// if click is outside the modal
if (this.opts.closeMethods.indexOf('overlay') !== -1 && !_findAncestor(event.target, 'tingle-modal') &&
event.clientX < this.modal.clientWidth) {
this._reasonForClose = tingleCloseClickOutside;/*new*/
this.close()
}
}
I guess Modal.prototype.close = function (force) {} also needs to be modified so that:
if (this.reasonForClose == tingleCloseNone) {
this._reasonForClose = tingleCloseButton;
}
from tingle.
Related Issues (20)
- Replacement for resize HOT 3
- v0.2 doesn't return object HOT 2
- How to set static modal in html? HOT 2
- Cannot select the texts in the modal HOT 4
- Remove button in footer HOT 1
- Modal destroys CLS (Cumulative Layout Shift) based on where the user is on page when opened. HOT 1
- Old v0.2.0 shown as latest release on Github HOT 1
- CSS cursor rule is causing Content Security Policy warnings HOT 1
- Ability to customise the close icon
- Hide scrollbar if modalHeight equals viewportHeight HOT 1
- Allow mobile breakpoint to be adjusted
- Keyboard use for component HOT 3
- Attach to existing node
- Handling of Enter-key
- Sticky Footer? HOT 2
- Question : Can you use tingle in a multi step form somehow ?
- Add Sass source styles
- img tag with loading="lazy" problem in some case
- Overflow scroll is just supposed to work? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tingle.