Comments (10)
[Update -- something is still not working correctly even after the fix below.]
I found the error. Same error was causing this to fail:
self.keywords.append({'find': [['turn', '*', 'the', 'outside', 'lights']], 'call': 'outsidelights'})
The fix is in search.py. wildcard_end was being set to 0 instead of -1 in this clause:
if (wildcard_end > -1):
wildcards_found[wildcard_counter] = q[wildcard_start:wildcard_end]
wildcard_start = 0
wildcard_end = -1
from siri-api.
Thank you for the report. I will look for this and try to fix it. Did you try to use a phrase instead of just a single word? Instead of ['turn', '', 'the', 'outside', 'lights']: ['turn', '', 'the outside lights']?
from siri-api.
No, I didn't realize that would work. I will try it.
On Sat, May 10, 2014 at 3:15 PM, HcDevel [email protected] wrote:
Thank you for the report. I will look for this and try to fix it. Did you
try to use a phrase instead of just a single word? Instead of ['turn', '',
'the', 'outside', 'lights']: ['turn', '', 'the outside lights']?Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-42753051
.
from siri-api.
I tried self.keywords.append({'find': [['*', 'the', 'garage']], 'call': 'garage'})
and as you described, it didn't work. But with a phrase it works: self.keywords.append({'find': [['*', 'the garage']], 'call': 'garage'})
. Your second example has to look like this: self.keywords.append({'find': [['turn', '*', 'the outside lights']], 'call': 'outsidelights'})
.
In the next version I will redesign the code and make it better documented. Maybe I will also improve the wildcard handling.
from siri-api.
Made the changes you suggested and yes, they work now! Thanks you.
Encountered a new problem. The following is not found even though the words and case all come through correctly:
self.keywords.append({'find': [['turn', '', 'the volume', '', 'the', '', 'room'], ['turn', '', 'the volume', '', 'the', '']], 'call': 'volumeupdown'})
from siri-api.
I can't test it right now but I think you just forgot the stars to declare the wildcards.
from siri-api.
That did paste strange in the post, but the asterisks are there in the code.
from siri-api.
I found your problem and solved it. I added a solution in the issue #6 branch which you can find here: https://github.com/HcDevel/Siri-API/tree/Issue-%236. To download it with git you can run this command: git clone https://github.com/HcDevel/Siri-API.git -b Issue-#6
.
Please let me know if this worked for you.
from siri-api.
Yes, that worked. Thanks.
from siri-api.
Thank you for the testing. I just merged the code to the master repository. I didn't change anything else so you don't have to update again.
from siri-api.
Related Issues (20)
- Siri internal Bing search?? HOT 2
- Squid dosent start on startup HOT 2
- Voice feedback support HOT 3
- No such file or directory proxy.pac HOT 10
- Google Siri turn on light one dont work HOT 1
- Squid The requested url could not be retrieved HOT 1
- Issue with iOS8 HOT 6
- google normally appears HOT 65
- Squid does not forward to Siri-API HOT 1
- plugin for siri api HOT 1
- Siri API installation on RPi HOT 1
- This page is unavailable HOT 5
- afetr run Squid ... HOT 8
- https resquest HOT 1
- Html respond auto close HOT 5
- add command HOT 13
- Deal with upper and lower cases HOT 6
- Search defect HOT 2
- Problem with Raspberry Pi and Python HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from siri-api.