callback_path with sub uri about omniauth_crowd

[robdimarco]

I upgraded this gem to the 1.0 version of OmniAuth, which I believe will fix this issue.

[combhua]

I wanted to update this ticket. I've verified the issue still exists.

I have implemented a fix for my apps locally, but it may be less elegant due to my lack of understanding of the project(s). I've found that the fix in various places has been to use the callback_url method instead of the callback_path method.

callback_path does not include all the pieces necessary to take into account the scenarios where an application is deployed to a sub-uri. As a matter of fact, callback_path is a part of callback_url as defined in oa-core/lib/omniauth/strategy.rb:

def callback_url
    full_host + script_name + callback_path + query_string
end

Note this mistake also exists in the included "developer" strategy that comes with omniauth

• https://github.com/intridea/omniauth/blob/master/lib/omniauth/strategies/developer.rb#L40
• https://github.com/robdimarco/omniauth_crowd/blob/master/lib/omniauth/strategies/crowd.rb#L22

I'll try to find some time soon (probably measured in weeks) to figure out how to write some tests to cover my change, verify what I'm doing doesn't break existing functionality and figure out how to submit it back to you. In the meantime, this might be useful for someone else or if someone with more time than me can get this fixed, that would also be awesome.

[robdimarco]

Reopened this and added a pull request to make the change from callback_path to callback_url. If you have a better patch and/or tests I would love it, but I will try to test out the branch with the patch.

[robdimarco]

Merged the change