Invalid data from readMemory about memoryjs

[Rob--]

Hey guys, I am interested on improving this library and adding a few features. After my exams are over I've got a busy summer so I can't promise anything, but I will try to find time to address some issues and also review the current PRs.

[AxDSan]

I have the same issue, I try to read from an address and sometimes I get random values, or I get 3, I think it's gotta be with the library, I have tried getting in contact with the author or the library #16 and I also have issues reading from memory, I'm pretty sure it's got to be with the library.

[Chank1e]

Oh, that's pretty cool.
I'm just learning C++ in university, so my knowledge is like "How to read file of numbers and do quicksort of them". But, as for me, possibility of reading memory in js is really cool.

Would be great if community will help Robert to do that work)

[idkRage]

You will also get wrong memory value if u forget to add ".exe" to process name

[AxDSan]

Digging up a little further, I think that 3 that we get it's just an error code...

const processObject = memoryjs.openProcess(processName);
console.log(JSON.stringify(processObject, null, 3));

var addr = 0x7ff662ff8ff2;

/// <summary> Getting ready to read the memory.
/// <err> error message (empty if there were no errors). </err>
/// <value> the value stored at the given address in memory. </value>
/// <see>Documentation at: https://github.com/Rob--/memoryjs#readmemoryaddress-datatype-callback</see>
/// </summary>
memoryjs.readMemory(addr, 'int', (err, value)=> {
  if (err === "") {
    console.log(value);
  }else{
    console.log("ERROR:", err);
  }
});

So when error message is empty it means that everything was OK, but if error is NOT empty, then it means something went wrong.

[Chank1e]

Ye, but why sometimes it's invalid value?
I tried to find error in C++ code, but didn't find.

Do you think that we only need ptr function to get valid data?

P.S. I think, that author will never continue memoryjs. Need to fork and try to find an error.

[AxDSan]

Don't really know, but as recently as yesterday he commented on my issue, and he mentioned he could add a helper function to make the pointers addresses part to work, so that gets me to think that probably he is motivated to work on the issues, he also have expressed he is not a really well experienced C++ developer, and to be honest, me neither, in fact I was having a little bit of trouble regarding on how to properly read and general usage of the library.

[AxDSan]

Hey guys, I am interested on improving this library and adding a few features. After my exams are over I've got a busy summer so I can't promise anything, but I will try to find time to address some issues and also review the current PRs.

Awesome! 💃

[p410n3]

You will also get wrong memory value if u forget to add ".exe" to process name

Well of course, you can attach to other modules as well. Technically