Comments (6)
That does fix it! How strange. I wish I could remember where I got the first config line; it worked as expected for a long time. Thank you so much for helping out, I never really expect that from community maintainers ❤️
Hopefully this issue will help someone in the future searching Google and save you the trouble.
For future reference the working config line looks like:
(add-to-list 'browse-at-remote-remote-type-regexps '(:host "^bitbucket.private\\.tld$" :type "stash"))
from browse-at-remote.
I dont't it was deprecated, but i'm seeing that format of this defcustom is slightly diff from what you're adding https://github.com/rmuslimov/browse-at-remote/blob/master/browse-at-remote.el#L76
Can you try adjusting to format with :host / :type fields as in the example above
from browse-at-remote.
Hello, I'm wondering if you have something specific set in your config.
- Can you please share output of
git config --get browseAtRemote.type
-
I assume if you call
(setq debug-on-error '(wrong-type-argument) debug-on-signal t)
before reproducing it will provide more details trace. -
Also curious what is in 'git remote'
I also just checked master from MELPA and it works fine for me. I guess it may be a local issue
from browse-at-remote.
- nothing set:
.emacs.d master ✓ ➜ git config --get browseAtRemote.type
.emacs.d master ✓ ➜
- Traceback looks the same w/ that flag set, unfortunately:
Debugger entered--Lisp error: (wrong-type-argument stringp nil)
browse-at-remote--get-remote-type("github.com")
browse-at-remote--file-url("/home/iwhitlock/.emacs.d/ian.org" 3281)
browse-at-remote-get-url()
browse-at-remote()
funcall-interactively(browse-at-remote)
call-interactively(browse-at-remote nil nil)
command-execute(browse-at-remote)
- Just the remote here on GitHub:
.emacs.d master ✓ ➜ git remote -v
origin [email protected]:gigawhitlocks/emacs-configs.git (fetch)
origin [email protected]:gigawhitlocks/emacs-configs.git (push)
Full Emacs version:
GNU Emacs 28.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.16.0) of 2022-12-27
from browse-at-remote.
Oh okay, I found some additional info.
I have this setting for another repo (censored slightly):
(add-to-list 'browse-at-remote-remote-type-regexps '("^bitbucket.private\\.tld$" . "stash"))
Having this setting breaks browse-at-remote
across all repos, but it used to be a valid setting. I guess it was deprecated in favor of git config --get browseAtRemote.type
?
In any case, removing this setting allows browse-at-remote
to work again. Up to you if you want to call that a regression or a deprecated feature. Thanks for the attention to the issue. Sorry if I'm reporting a not-bug.
from browse-at-remote.
I think this sort of breaking change could have been handled a bit more gracefully by this package... as it breaks all users who have customized browse-at-remote-remote-type-regexps
.
The problem seems to be here: (string-match-p (plist-get plist :host) host)
.
(plist-get plist :host)
will return nil
for old-style definitions, which will not be accepted by string-match-p
.
from browse-at-remote.
Related Issues (20)
- Private bitbucket repos are not supported HOT 3
- How to select or change remote HOT 3
- Release version HOT 1
- browse-remote-prefer-symbolic does not fallback to git revision in detached HEAD state
- [feature-request] browse-*from*-remote: given a url, open the file/line/commit it points to HOT 6
- Line numbers in URL even though I didn't select any line HOT 3
- Tag version 0.14.0 HOT 2
- support SSH session HOT 1
- `apply: Wrong number of arguments: #<subr cons>, 1` when tracking local branches HOT 1
- Allow more customization of domain based on remote HOT 13
- Feature request: support Gogs and/or Gitea
- prefer-symbolic nil causes 404 in bitbucket
- Wrong remote selected
- Can't browse at remove after the package update HOT 2
- Can't browse custom domain even with set browse-at-remote-remote-type-domains HOT 4
- refs%2Fheads%2F is added to URL for type stash, resulting in broken link
- open with gitlab without starting with `https://`
- Unsure what remote type should be used for heroku
- browse-at-remote opens heroku when it should open github
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from browse-at-remote.