A sort of sections on page refresh about js-assessment

[ashleygwilliams]

hi @Jrizzi1 ! this is a duplicate of #61 - the tests are in a random order because they are loaded using require.

a few weeks ago we decided to close the issue- but we are currently working on some rewrites as we move to a major version release, and i think that this is at least worth reconsidering. i can empathize with getting disoriented!

@jmeas @kadamwhite thoughts?

[ashleygwilliams]

OH ALSO: thank you so much for contributing an issue, @Jrizzi1 👍

[jamesplease]

I'm thinking we could potentially just get rid of require altogether. What we would do instead is just type out the filenames manually in the test file and use browser globals.

Loading each script manually is old-school, and using globals is bad practice, but in this case these things work really well, I think. Because of the fact the app files are stubbed out, nobody will need to go in and add new script tags when they clone this lib to write some code. Also, the browser globals will already be added by us in those stubs.

The only time someone would need to change either of these is if they planned to add new tests, and an instruction on how to do that would be easy to add to the README, I think.

What we get in exchange for those two inconveniences are:

1. assurance that the tests load in the same order, always
2. removal of nasty AMD wrapper code in every file
3. removal of the require config file

Thoughtz?

[ashleygwilliams]

yeah i am so into this

[jamesplease]

I can try to put together a PR tonight!

[ashleygwilliams]

cool. i'mma ship the new browser deps stuff soon, so there shouldn't be a conflict.

[ashleygwilliams]

yo @jmeas - did you get to this yet? if not i might try to tackle it tonight cuz it's blocking

[jacobroufa]

This should be fixed by #112. 👍

[ashleygwilliams]

solved with #112, closing