Comments (5)
This crate requires: (1) a spawn
function that spawns a 'static future, and; (2) a block_on
function that blocks the current thread on a future. The second is only needed for the only fully-safe abstractions we could come up with.
Unfortunately, it seems tokio doesn't support a block_on
feature that can be called from an async context (as per the docs of Runtime::block_on
). I think this is a blocker for using tokio (as the safe abstractions would end up panicking). The unsafe interface should still work with tokio
though.
from async-scoped.
is this the equivalent? https://tokio-rs.github.io/tokio/doc/tokio/task/fn.block_in_place.html
from async-scoped.
Nice find! The function takes a FnOnce
and blocks on it, but what we currently need is a function that takes a Future
. I think we should be able to use this functionality for instance, by running a single-thread executor of the Future
we wish to drive within the FnOnce
passed to block_in_place
. However, we have to evaluate this a bit more carefully, and ensure complete safety.
Unfortunately, I can't provide a timeline for doing this yet. I could guide you on this, if you are interested in providing a PR.
from async-scoped.
@stevemk14ebr I tried a tokio implementation in this PR: #4 . See tests for example usage.
tokio's block_in_place
is such a great functionality; interestingly it prevents a particular deadlock that happens with deep recursive usage of Scope
. However, it can only be called from an async context, so slightly different from similar functionality of async_std.
from async-scoped.
Thanks for taking the time to work on that!
from async-scoped.
Related Issues (19)
- panic when calling scope_and_block HOT 7
- Tokio 1.0? HOT 3
- Compilation error after Rust nightly 2021-01-10 HOT 12
- Compile fails when using async-std without the attributes feature enabled HOT 2
- Question about `spawn_cancellable` HOT 6
- Compilation error, failed inference on closure HOT 3
- Return result containing references HOT 2
- Support for spawn_blocking HOT 5
- Support for user-provided runtime HOT 5
- Why is async_scope blocks some writes to file? HOT 2
- Allow async block in `scope_and_block` and `scope_and_collect` HOT 1
- docs bug
- Question: using async-scoped with for_each_concurrent HOT 2
- Release async-scoped 0.9 version HOT 7
- scope_and_collect should return results in order of submission HOT 2
- Limiting concurrent tasks HOT 1
- handle references in function results HOT 4
- Doc request: full minimal working example, including main HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from async-scoped.