Comments (11)
@simonvizzini If you do esw -v what version does it say? That prints out the eslint version. I don't think eslint is the cause but you never know lol.
from eslint-watch.
Also can you try saving multiple times and let me know if it picks up the file changes? I have been seeing it not pick up the first save, but after that it continues to lint fine.
It also seems to only happen when passing in multiple arguments. Passing in a single directory works as intended.
from eslint-watch.
esw -v outputs "1.5.1" (just saw that eslint 1.6.0 is out, so I'll give it a try). I tried saving multiple files multiple times, but still no luck. I also just tried to watch just one folder but that doesn't work for me either.
I guess this could be a problem in the chokidar
module instead. Current version is 1.2.0 (released a week ago) and this version has been installed as a dependency of eslint-watch, so maybe something is broken there. I will try to manually setup a file watcher with chokidar and see if it detects any changes. Unfortunately I have to leave now, but will try this on Monday and report back. In the meantime: have a nice weekend! =)
from eslint-watch.
Have you tried using 1.2.5 or 1.2.6 for eslint-watch? I am trying to figure out when this was introduced.
Neither really do much. But It all seems to revolve around that keylistener I put in.
from eslint-watch.
My findings suggest that something in watcher.js
messes up the input glob.
Because if I run esw . -w
or esw ./ -w
I will get proper linting but not any watcher that works. And if I just run esw -w
and let it use the default ./
path the watcher works as it should.
I don't have time right now to debug this properly but hopefully this helps narrow down the scope. I also took a quick look at chokidar 1.2.0 but it works as it should with .
or ./
.
from eslint-watch.
@simonvizzini @Cordazar Sorry for the delay in getting this fixed. I have been busy with work and life. I will make an effort this week in getting this resolved.
from eslint-watch.
@simonvizzini @Cordazar I have a fix out there pending a review. It seems like all the magic that was put into the watcher was unneeded bloat. If you wouldn't mind verifying that the fix works for you, that would be awesome and would help a lot. It's on the branch watch-fix
. Sorry again for the delay.
from eslint-watch.
I have released what I had. It should be on version 2.1.3. I had someone test it out and they couldn't reproduce it on their machine.
from eslint-watch.
Hey @rizowski, so sorry for the late response yet again. As I was getting closer to a deadline, my workload started to increase exponentially :-) But now the dust has almost settled, and I definitely want to keep my node package dependencies up-to-date. I'll update all my node modules in the next couple of days and let you know if everything is okay. Thanks a lot so far and I promise to give feedback asap
from eslint-watch.
Hey again! So I finally updated my npm packages and I can confirm that the file watcher now works fine on Windows. Thanks!
from eslint-watch.
@simonvizzini Good to hear!
from eslint-watch.
Related Issues (20)
- esw --watch throws EPERM on Windows HOT 4
- Doesn't track file changes with --ext js,jsx HOT 4
- esw results are doubled/shown twice HOT 6
- Option to not print "clean" message; only errors HOT 4
- Changing branches on git triggers dozens of concurrent `eslint` processes to be created HOT 3
- Hope to have more comfortable information. HOT 2
- npm audit high priority warning HOT 1
- Error parsing '--rule' CLI option HOT 2
- Missing Module HOT 3
- Running `esw --changed -w` causes non-JS files to attempt to be linted HOT 4
- `--clear --color -w` causes duplicated output HOT 4
- Slowness, maybe because it's not just linting an individual file? not sure HOT 1
- Watch mode does print to the console HOT 4
- ESLint 8 support HOT 2
- "The --print-config option must be used with exactly one file name." HOT 1
- Nothing happens HOT 6
- `ENOENT` of `eslint` causes a silent exit rather than an expected error message to install `eslint`
- Print a message upon file watch trigger HOT 3
- --watch-ignore should include by default the ignored patterns
- Tried it and had to uninstall it HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-watch.