Coder Social home page Coder Social logo

Document minimum log rounds about comeonin HOT 4 CLOSED

riverrun avatar riverrun commented on August 28, 2024 1
Document minimum log rounds

from comeonin.

Comments (4)

riverrun avatar riverrun commented on August 28, 2024

Yes, it's documented in the gen_salt function, but not in the hashpwsalt function, which might be confusing. Maybe raising an error would provide more forceful 'documentation' :)
I'll let you know what I decide on.

from comeonin.

pdilyard avatar pdilyard commented on August 28, 2024

At the very least I'd recommend adding a little note to the README in step 4 of the Installation section.

from comeonin.

riverrun avatar riverrun commented on August 28, 2024

I've just released version 2.4, and these are the changes:

  • If the log_rounds is less than 4, then gen_salt will use 4 log_rounds, and if log_rounds is more than 31, gen_salt will use 31 log_rounds (this is the default behavior for the OpenBSD version of bcrypt). If the log_rounds argument is the wrong type, then an error will be raised.
  • Added documentation to bcrypt_log_rounds in the Config module.

from comeonin.

pdilyard avatar pdilyard commented on August 28, 2024

Awesome, thanks! I think this will help keep a lot of people from tripping up.

from comeonin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.