Comments (9)
@ritwik12 I find the idea of @pavan-pan better. It will increase the understanding of code as well. What do you think @ritwik12 ?
from virtual-assistant.
I have been working on reorganizing the code and using a CMake system to build it. Once I have the system running, I will need to re-add some features that were added later (email support etc.). I will try to send a PR by next week.
from virtual-assistant.
I agree with refactoring/restructuring in this way, where pieces of logic are extracted into separate src files (.c) but only header files (.h) are included.
Including src files is commonly considered bad practice, while the approach proposed here supports modular design, which is better and a lot easier to maintain, scale and test/debug.
I have started working on refactoring the code in this way.
from virtual-assistant.
@pavan-pan There's no specific reason as such. it's just that previously it was a single main.c file consisting of all the functionalities. Then later @igo4Jesus in #31 split it in different files for better code readability. If you think something else is better. Please suggest.
from virtual-assistant.
@riya-17 I would like your reviews here
from virtual-assistant.
My idea is to divide the entire program into modules consisting .c and .h files. So every module is loosely coupled. Instead of adding .c files, .h files are included instead. When the code grows bigger, its easier when everything is organized in modules.
from virtual-assistant.
@pawan-pan sure, please go for it and send a PR
from virtual-assistant.
@virajmalia That's great, will wait for your PR, Thanks !!
from virtual-assistant.
@RoyMattar Thanks for taking interest!!
from virtual-assistant.
Related Issues (20)
- Update Knowledge base (corpus)
- Ineligible Repository For Hacktoberfest HOT 2
- Introduce make install and uninstall in makefile HOT 3
- Things defined in main.c also defined in init_config.c HOT 3
- [ideas pls] what to contribute HOT 1
- Some code safety insights HOT 1
- running into problems trying to compile the code
- Does the strlen function need to be recalculated every round of the for loop? HOT 1
- blank spaces HOT 4
- ALSA lib pcm_dmix.c:1108 error HOT 3
- README addition for EMAIL
- Increase array size HOT 3
- Add support for MacOs
- Issue with classification HOT 7
- Create Documentation HOT 10
- Reduce time complexity HOT 11
- Create a Makefile HOT 4
- Reorgainize preprocessor macros to outside of main function calls HOT 4
- Add basic math capabilities HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from virtual-assistant.