Coder Social home page Coder Social logo

Comments (4)

fuyufjh avatar fuyufjh commented on September 25, 2024 1

Feature is not yet implemented: Window function with empty PARTITION BY is not supported yet

@stdrc Do you think it's "not yet implemented"? I think we intended to forbid such thing to avoid bad query, just like the case of nested-loop join.

from risingwave.

lmatz avatar lmatz commented on September 25, 2024

BTW, if the workaround works for most cases, shouldn't we just rewrite the query automatically?

from risingwave.

fuyufjh avatar fuyufjh commented on September 25, 2024

BTW, if the workaround works for most cases, shouldn't we just rewrite the query automatically?

Had better not to do so. partition by 1, similarly to the nested-loop join trick, will make it impossible to process parallelly and thus easily become a performance bottleneck. Writing partition by 1 also let users know what he is doing.

from risingwave.

stdrc avatar stdrc commented on September 25, 2024

Feature is not yet implemented: Window function with empty PARTITION BY is not supported yet

@stdrc Do you think it's "not yet implemented"? I think we intended to forbid such thing to avoid bad query, just like the case of nested-loop join.

Yes we didn't support this because we don't want user to write such bad query very easily.

Although I think give a better error message to advise the user be careful and use "partition by 1" if it's really needed.

from risingwave.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.