Comments (2)
It appears that Dockerfile.hdfs
is quite outdated. 😄 We've already switched to build the dashboard artifact in place since #12421.
Lines 15 to 25 in 5a85fe9
Specifically for this case, I would strongly suggest maintaining Dockerfile.hdfs
as an extra step in Dockerfile
to avoid such inconsistencies.
However, the issue still exist if there's no --dashboard-ui-path
specified. We'll proxy to githubusercontent.com
then at runtime and it's not versioned. This affect the users who directly download the binary directly or through Homebrew
.
risingwave/src/meta/src/dashboard/proxy.rs
Lines 76 to 79 in 5a85fe9
from risingwave.
Plan:
-
Introduce a new crate
dashboard
to build the dashboard assets in the build script (build.rs
) conditionally based on the configuration, providing a unified entry for serving dashboard assets.- Always build and embed in the binary for releases, requiring
nodejs
toolchain. - Do not build but proxy to GitHub for debug/CI builds, unless asked to build.
- Always build and embed in the binary for releases, requiring
-
The
meta
crate will depends ondashboard
and be no more aware of the source of the dashboard assets.ui-path
is deprecated as there's no need of external assets.
from risingwave.
Related Issues (20)
- EOWC: close `RANGE`/`SESSION` window with watermark
- `ALTER TABLE` will refresh previous snapshot values for absent cells
- bug: fail to load workload identity token on azure environment
- cherrypick feat(udf): add metric of UDF memory usage (#16922) to branch release-1.9 HOT 1
- when using external schema, `struct`'s fields are not shown in `describe <table>`
- Division by zero exception HOT 7
- e2e test time increased from 15min to 20min in ci HOT 1
- Performance lost after using `BTreeMap` for WITH properties
- hint user when column not found HOT 1
- bug: CI failure: integration test (madsim): progress not within bounds 0.9
- bug(main-cron): pulsar source check: gRPC request to meta service failed: Unknown error HOT 3
- feat: expose dedicated source for table in system catalog rw_sources
- Reclaim space more aggresively for table with vnode table watermark specificed (table with range delete)
- system table for source health status HOT 1
- SSL configurations is not supported for schema registry HOT 2
- Don't let jni_core depends on (the whole) storage crate HOT 2
- dep: try to use either aws-lc-rs or ring
- Rework ci labels
- reorganize directories at the root of the repo
- error in metabase: function has_any_column_privilege does not exist HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from risingwave.