Add logging option about wafer

Yes! We need logging. We would really welcome your help in implementing it.

[gsquire]

Here is the log format I will use. It will contain as much information that is parsed from the request. I am going to try and finish it this weekend.

Sweet. Let me know if you need any help. Meanwhile, I am trying to improve the throughput of the platform.

[gsquire]

I implemented some very basic logging in my fork. The only problem I had was dealing with statuses other than 200. It looks like the code now sends a 200 and then checks to see if the file or "resource" exists and if it doesn't sends a 404 on top of the existing 200 it sent. Is this a bug?

Good question.

Write now, the status codes are handled entirely by server(). As such, nope.c itself has no idea about the status codes, because server doesn't return anything. One thing we could do is make server() return a status code, which then your logger could use.

What do you think?

[gsquire]

That sounds great. Unless you foresee wanting to return anything form server() in the future, a status code would be really helpful without having to change too much of the code now.

The only problem is, there's no way to enforce return values in C.

[gsquire]

Oh I see, considering that there is a chance that multiple functions may return different values at different times. I will see if I can find an alternative.

[gsquire]

Until there is a way to successfully get return values, I don't know how we can go about logging them. For now all I can log is a request, the ip, and a time stamp.

[truongminh]

I agree with @gsquire. A status code is really helpful and should be compulsory.

One more problem with logging involves the multithreaded model introduced in version 0.0.4 alpha.
Should the logger be run by the main thread (in cleaner() for example) or by worker threads?

If you look at the 0.0.5 branch, I have made some significant changes to support what you are looking for:

the server function now takes the form server(Request * request, Response response )

Response is a struct in the form of

typedef struct struct_response {
    int fd;
    char **headers;
    int flags;
    int apiFlags;
    int status;
} Response;

nopeapi sendHeader family of functions will automatically set the status. Or the users could change it somewhere in the server function. Either way, you can now check the Response.status upon return to get the status.