Coder Social home page Coder Social logo

Comments (2)

latonz avatar latonz commented on May 23, 2024 1

Thanks for creating this issue. The documentation of Mapperly in those areas (matching and priority of mappings) definitely needs some improvements (I created #196 to track this).
As the original matter of this issue seems to be resolved, I'll close this for now.

from mapperly.

mshgh avatar mshgh commented on May 23, 2024

Disregard my comment, please. I have realized

  • none of my custom mapping methods were actually used.
    The generated implementation was identical to the one I provided. Lesson learned - I don't need custom method in case target class has constructor accepting source type. Pretty cool!
    private EntityId StringToEntityId(string id) => new EntityId(id); // not needed!
  • the custom mapping methods cannot be static
    It's a bit of surprise as mapper class can be static, but not a big deal. Fixed

note: I have realized as well the type match takes into consideration nullability, I guess this is intentional
this method is used (according to my classes definition)

private string? EntityIdToString(EntityId? id) => id?.Value;

but this one is ignored and .ToString() is used instead

private string EntityIdToString(EntityId id) => id.Value;

from mapperly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.