Comments (3)
I'm not really familiar with your code, so I won't send a PR. But I did spend an hour looking through your code and my suggestion is as follows:
Change this line
To something like this:
.Where(x => x.IsAccessible()
&& x.SetMethod?.DeclaredAccessibility.HasFlag(Accessibility.Public) == true
&& x.GetMethod?.DeclaredAccessibility.HasFlag(Accessibility.Public) == true)
Or something similar.... You get the idea.
Thanks!
P.S. A unittest can be like this:
[Fact]
public void ShouldIgnorePrivatePropertySetter()
{
var source = TestSourceBuilder.Mapping(
"A",
"B",
"class A { public string StringValue { get; set; } }", //lets make it public on the source, but private on the destination
"class B { public string StringValue { get; private set; } }");
TestHelper.GenerateSingleMapperMethodBody(source)
.Should()
.Be(@"var target = new B();
return target;".ReplaceLineEndings());
}
from mapperly.
🎉 This issue has been resolved in version 2.4.1-next.1 🎉
The release is available on:
- GitHub release
v2.4.1-next.1
Your semantic-release bot 📦🚀
from mapperly.
🎉 This issue has been resolved in version 2.5.0 🎉
The release is available on:
- GitHub release
v2.5.0
Your semantic-release bot 📦🚀
from mapperly.
Related Issues (20)
- Disable Auto Mapping HOT 1
- Raise diagnostic for memberpaths that mistakenly specify the type name
- Ignoring a property based on the attribute on the property instead of the mapper attribute HOT 5
- Add the GeneratedCodeAttribute to generated code HOT 3
- Add support for dynamic object mapping
- Bug in nullability and external mappers HOT 2
- UseDeepCloning with Action Properties
- `EnumMappingStrategy.ByName` not working for `IQueryable` mapping
- Duplicate source generated mapping methods for collection properties HOT 5
- Add support for EnumMemberAttribute HOT 3
- Consider adding strong name signing HOT 2
- Mapperly does not work on .NET Framework 4.x. HOT 8
- Mapping a collection property of nullable type elements affects other non-related mapping methods HOT 2
- Property specific static mapper HOT 1
- Partial select based on column names HOT 8
- Mention contributors in the release notes
- IReadOnlyCollection as interface param uses Length instead of Count when source is an array HOT 11
- Mapperly does not properly map DateTimeOffset to gRPC entities HOT 3
- Emit warning when a mapping doesn't use the source value. HOT 2
- Support `From` and `To` static factory methods HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mapperly.