Coder Social home page Coder Social logo

Comments (4)

jservonnat avatar jservonnat commented on June 30, 2024

Suggestions for the form of html_table_line from the user side (with p1, p2, px being climaf objects of type figure):

  • html_table_line( { 'My figure p1' : p1, 'My figure p2' : p2, 'My figure px' : px})
    Then html_table_line would loop on the elements of the dictionary. The facets will be used as titles and the values are the plots.
    Or:
  • html_table_line( plots=[p1, p2, px], titles=[ 'My figure p1', 'My figure p2', 'My figure px' ] )

The first form is more compact and pretty logical in a way. The second form is more basic, maybe more readable. Please give your comments!

from climaf.

senesis avatar senesis commented on June 30, 2024

I would vote for first form. This would lead to rename the present function html_table_line to something like 'html_table_line_with_func' (because it is calling some function iteratively for computing figures).
Alos : the new html_table_line should allow for a 'thumbnail' argument, in which case the dict argument could be a list (because titles would be replaced by thumbnail images)

from climaf.

mpmoine avatar mpmoine commented on June 30, 2024

Form 1 suggested by Jerome sounds the best to me too.

But I would keep "html rendering" and "plot creation" as separated operations. Thus, I would advocate in favor of removing plot creation step (call to a function) from html_table_lines.

Intuitively user comptes his diags, creates associated plot objects first and call for an html rendering in a second step. Moreover he may want to draw different types of plot (time serie, map, slice) on a same line that would not be possible with a "create_plot" function embedded within html_tables_lines (or this woud require to pass an additionnal dictionary in arguments with the list of plot types).

from climaf.

senesis avatar senesis commented on June 30, 2024

Agree. Suggestions implemented in V0.10

from climaf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.