Comments (2)
It has to do with the API call to find the previous and next games. nhl_api/info.py
at/about line 137 in team_previous_game()
, there's a check for the truthiness of the results of fetching the team's schedule. It seems that if the team is done for the season, the API is returning an empty list. Two lines later, if the result was not truthy, the code nonetheless attempts to pull element 0 from the empty list and use it in an expression. I'm not certain what the original intent of that lump of code was, I've got a work-around that forces the previous game and next game data points to null when there's no data from the API call.
So if you're following a team that's out of the running, the team summary shows '--------' for the previous and next game data, but teams that still have upcoming games will show their next/previous games in the team summary.
But the above change caused another issue. At/about line 152 of data/scoreboard.py
in Scoreboard.__init__()
, the code presumes that overview["homeTeam"]
and overview["awayTeam"]
contain "onIce"
elements. I haven't figured out why they don't, but it's probably a side effect of returning null for previous and next games from above. I've got a quick work around for this, but it feels like a hack. I need to trace what happens to the results from team_previous_game()
to see if I can deduce what a useful non-answer would look like.
from nhl-led-scoreboard.
Fixed in 1.8.3
from nhl-led-scoreboard.
Related Issues (20)
- Fresh install not working HOT 8
- Cannot get past loading screen HOT 4
- Current update v1.6.11 shows that v1.6.12 is available. HOT 1
- MQTT user/pass HOT 3
- live_mode when set to false should not need to call NHL API HOT 1
- Graphics for 128x64 HOT 2
- API connection error? HOT 2
- I'm stuck in the Loading Loop, but I think I have a different issue than the others. HOT 1
- New Day Error
- Error with nhl-api-client (No matching distribution found) when installing HOT 1
- NOT All Teams Working HOT 3
- Scoreboard is stuck on "off day" with no last or next game data displayed HOT 1
- animation when preferred team wins
- Board not loading after update
- AttributeError: 'Data' object has no attribute 'current_round' HOT 6
- ModuleNotFoundError: No module named 'diskcache' HOT 10
- Independent "Include only your preferred teams" for EACH time the board is used. Maybe independent settings PER board PER state?
- OWM weather provider will stop working June 2024 HOT 1
- Display stops showng anything on 64x32 4mm pitch LED board HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nhl-led-scoreboard.