Error after nhl-setup when not simple setup about nhl-led-scoreboard

[falkyre]

@riffnshred this can be closed now. It's part of the 1.6.10 version you pushed out last week.

[falkyre]

I just downloaded a fresh install of the latest repository (1.6.9) so no config.json was included and I had to run the nhl_setup. Ran simple setup and the goal_animations has the pref_teams_only: true.

I see in another issue you raised that you were running an older version of the scoreboard. Did you create the simple config with that version?

[Overboard-code]

No. I deleted the whole directory tree. Then did a 'git' of the latest version 1.6.9 then I ran the config simple. Then I ran the config again making it complex. I expected'false' as the value Instead it was empty. the simple config had 'true' for me as well.

[falkyre]

So when you redid the setup, you selected false for the goal animations? And it didn't write anything back to the config ?

[Overboard-code]

Correct.

…

On Fri, May 6, 2022, 5:13 PM Sean Ostermann ***@***.***> wrote: So when you redid the setup, you selected false for the goal animations? And it didn't write anything back to the config ? — Reply to this email directly, view it on GitHub <#374 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMVDFMOOJBSKHEKVKNZ6GODVIWDPBANCNFSM5VIWNSKQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[falkyre]

Tried 3 times, can't recreate the issue you are seeing. What I do see from your run of the nhl_setup above is that it looks like the prompt specific to the goal animations did not render correctly.

🥅 Do you want goal animations for only preferred team?

There should be an answer (Yes or No) no matter what (it will default to whatever it pulled from your original config.json)

At this point, I'd chalk it up to one of those un reproducible things. Are you able to reproduce the issue consistently?

[Overboard-code]

Yes I agree. I ran nhl-setup again and saw:
🥅 Do you want goal animations for only preferred team? No
And it worked fine in the config:

      "goal_animations": {
            "pref_team_only": false
        }

Thanks so much for your time.

[Overboard-code]

Found it. If I just hit Enter instead of 'Y' or 'N' for goal animations it fails. If I type 'Y' or 'N' on the keyboard it works. I tried it three times with the same results.
Hit N and I see:
🥅 Do you want goal animations for only preferred team? No
Hit Enter and I see:
🥅 Do you want goal animations for only preferred team?

[falkyre]

OK, was able to recreate and fix the problem. Thanks for finding it. I'll add the fix and the new binary in a PR for @riffnshred to add to the next release.

[Overboard-code]

Thanks so much! I really appreciate what you are doing.

[falkyre]

This is fixed in #377

@riffnshred will just need to merge it for the next release.