Comments (11)
@riffnshred this can be closed now. It's part of the 1.6.10 version you pushed out last week.
from nhl-led-scoreboard.
I just downloaded a fresh install of the latest repository (1.6.9) so no config.json was included and I had to run the nhl_setup. Ran simple setup and the goal_animations has the pref_teams_only: true.
I see in another issue you raised that you were running an older version of the scoreboard. Did you create the simple config with that version?
from nhl-led-scoreboard.
from nhl-led-scoreboard.
So when you redid the setup, you selected false for the goal animations? And it didn't write anything back to the config ?
from nhl-led-scoreboard.
from nhl-led-scoreboard.
Tried 3 times, can't recreate the issue you are seeing. What I do see from your run of the nhl_setup above is that it looks like the prompt specific to the goal animations did not render correctly.
🥅 Do you want goal animations for only preferred team?
There should be an answer (Yes or No) no matter what (it will default to whatever it pulled from your original config.json)
At this point, I'd chalk it up to one of those un reproducible things. Are you able to reproduce the issue consistently?
from nhl-led-scoreboard.
Yes I agree. I ran nhl-setup again and saw:
🥅 Do you want goal animations for only preferred team? No
And it worked fine in the config:
"goal_animations": {
"pref_team_only": false
}
Thanks so much for your time.
from nhl-led-scoreboard.
Found it. If I just hit Enter instead of 'Y' or 'N' for goal animations it fails. If I type 'Y' or 'N' on the keyboard it works. I tried it three times with the same results.
Hit N and I see:
🥅 Do you want goal animations for only preferred team? No
Hit Enter and I see:
🥅 Do you want goal animations for only preferred team?
from nhl-led-scoreboard.
OK, was able to recreate and fix the problem. Thanks for finding it. I'll add the fix and the new binary in a PR for @riffnshred to add to the next release.
from nhl-led-scoreboard.
Thanks so much! I really appreciate what you are doing.
from nhl-led-scoreboard.
This is fixed in #377
@riffnshred will just need to merge it for the next release.
from nhl-led-scoreboard.
Related Issues (20)
- Unable to connect to EC HOT 8
- LED brightness control HOT 1
- LED matrix showing with light blue tint HOT 3
- Continual Reloading and Not getting all Information HOT 3
- Frequent Crashing HOT 6
- Board presents as off day when there's a game scheduled HOT 1
- Fresh install not working HOT 8
- Cannot get past loading screen HOT 4
- Current update v1.6.11 shows that v1.6.12 is available. HOT 1
- MQTT user/pass HOT 3
- live_mode when set to false should not need to call NHL API HOT 1
- Graphics for 128x64 HOT 2
- API connection error? HOT 2
- I'm stuck in the Loading Loop, but I think I have a different issue than the others. HOT 1
- New Day Error
- Error with nhl-api-client (No matching distribution found) when installing HOT 1
- NOT All Teams Working HOT 3
- Scoreboard is stuck on "off day" with no last or next game data displayed HOT 1
- animation when preferred team wins
- Board not loading after update
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nhl-led-scoreboard.