Comments (7)
I do use ansible lint but have not used it in this project. Just running --fix might change more then needed. But if you feel up to it you could also just run it, make a PR see if the changes are solid.. unless @guenhter has some time?
from ansible-gitlab-runner.
When we run this and make everything linted, do you think it would be worth add this to the CI pipeline so that future PR's always fail in case they are not linted?
from ansible-gitlab-runner.
That would make sense yes.. a PR could have a check for that.
from ansible-gitlab-runner.
Once you achieve no errors, it is worth adding it to CI.
from ansible-gitlab-runner.
@guenhter Thx for some progress.
Girls from Warsaw are waiting for part two.
from ansible-gitlab-runner.
@abielan At the moment, I'm very busy and don't have much time for this. But feel free to tackle a few of the linter issues and submit it as PR. I'm happy to review and merge that then in a timely manner.
from ansible-gitlab-runner.
Seems this message did not get a lot of love. This does not mean it was not seen but time wise might not have made it to proper attention. This is just the clean up action ;)
from ansible-gitlab-runner.
Related Issues (20)
- Support for AlmaLinux HOT 3
- Support for (pre,post)_*_script in gitlab-runner config HOT 2
- Set additional services is failing due to missing variable HOT 8
- Invalid config.toml for azure and gcp cache HOT 3
- How to set custom_build_dir_enabled as variable HOT 1
- Error when upgrading from gitlab-runner version 15.0.0 to 16.6.0 HOT 2
- Default branch name HOT 5
- Debian Unhold: Failed to find package from ansible-core >=2.16 HOT 1
- Support for docker tmpfs options HOT 2
- Galaxy role renamed back from ansible-gitlab-runner to gitlab-runner HOT 10
- Reactivating Tests: Topic "systemd and docker" HOT 2
- Causes failures when included by ansible-lint HOT 1
- Can't find package `gitlab-runner` HOT 5
- tls_ca_file not included in container registration HOT 1
- Runtime owner and group for container setup HOT 1
- Deploy multiple executors to single VM
- Fails when GPG key of https://packages.gitlab.com/runner/gitlab-runner is expired HOT 7
- Gitlab-runner does not get deployed correctly after adding additional lines to the configuration HOT 1
- Runner is not being unregistered from Gitlab instance, when setting `state: absent` HOT 2
- (Debian) Install GitLab Runner fail when update in 22.04 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ansible-gitlab-runner.