Coder Social home page Coder Social logo

ansible-lint about ansible-gitlab-runner HOT 7 CLOSED

psztoch avatar psztoch commented on June 7, 2024
ansible-lint

from ansible-gitlab-runner.

Comments (7)

riemers avatar riemers commented on June 7, 2024

I do use ansible lint but have not used it in this project. Just running --fix might change more then needed. But if you feel up to it you could also just run it, make a PR see if the changes are solid.. unless @guenhter has some time?

from ansible-gitlab-runner.

guenhter avatar guenhter commented on June 7, 2024

When we run this and make everything linted, do you think it would be worth add this to the CI pipeline so that future PR's always fail in case they are not linted?

from ansible-gitlab-runner.

riemers avatar riemers commented on June 7, 2024

That would make sense yes.. a PR could have a check for that.

from ansible-gitlab-runner.

psztoch avatar psztoch commented on June 7, 2024

Once you achieve no errors, it is worth adding it to CI.

from ansible-gitlab-runner.

abielan avatar abielan commented on June 7, 2024

@guenhter Thx for some progress.
Girls from Warsaw are waiting for part two.

from ansible-gitlab-runner.

guenhter avatar guenhter commented on June 7, 2024

@abielan At the moment, I'm very busy and don't have much time for this. But feel free to tackle a few of the linter issues and submit it as PR. I'm happy to review and merge that then in a timely manner.

from ansible-gitlab-runner.

github-actions avatar github-actions commented on June 7, 2024

Seems this message did not get a lot of love. This does not mean it was not seen but time wise might not have made it to proper attention. This is just the clean up action ;)

from ansible-gitlab-runner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.