SSL/TLS support about riemann-ruby-client

[eric]

I believe that ruby establishes a connection when TCPSocket.new() is called.

Some of the changes you made appear to thwart the existing logic that implements timeouts on establishing connections.

Instead of overriding blank_socket, you may be better off wrapping connect_nonblock with your SSL logic and return the SSL socket from the socket method in your SSLSocket implementation.

[nukemberg]

great input, i re-wrote as per your suggestions, much better now. There are still OpenSSL constants in TcpSocket unfortunately - i could override readpartial and write but that seems excessive.

[eric]

My thought would be that it would make more sense to override the methods instead of including exceptions in a class that isn't relevant.

[nukemberg]

Makes sense. Another question regarding Riemman::Client interface: do we want to have the TLS client exposed under client.tcp? the current implementation which automatically chooses between UDP and TCP will probably be useless for people using TLS and client.tcp may confuse people.

[nukemberg]

I added spec tests, however, i'm not sure if I sure if I should save the certificates in fixtures as at least the ca should match riemann instance certificates. How is testing done? i don't see the test config of riemann in the repo

[jamtur01]

@avishai-ish-shalom Want to submit this as a PR and we'll do from there?

[jamtur01]

Closed in favor of #24.