Bug: Single quotes are inserted as `'` about plywood-gallery-for-vscode

[Rickaym]

I believe this issue is within the gallery "Functions"
https://github.com/kolibril13/plywood-gallery-functions/blob/main/gallery_assets/gallery_parameters.json#L73-L78

[kolibril13]

Actually, this is on purpose, as can be seen here:

https://github.com/kolibril13/plywood-gallery/blob/ab4aaf9253778aac78e7f77aff5adaf27acd297b/plywood_gallery/plywood_tools.py#L93

When I would put the single quote instead of ' the JavaScript for the website would not work here:

https://github.com/kolibril13/plywood-gallery/blob/ab4aaf9253778aac78e7f77aff5adaf27acd297b/plywood_gallery/jinja2_template/template_index.html#L40

[KekOnTheWorld]

Is there any specific reason you are using .innerHTML over .innerText?

[kolibril13]

No, there is no specific reason.
What advantage would innerText have?

[KekOnTheWorld]

No, there is no specific reason. What advantage would innerText have?

Like the name suggests, it inserts text as text and not as html. This should also be prefered because of cross site scripting and such.

[KekOnTheWorld]

For example, these will do different things

// Will insert as text (=> you will see <p>Hello World</p>)
document.body.innerText = "<p>Hello world!</p>"

// Will insert as html (=> you will see 'Hello World' as a paragraph element)
document.body.innerHTML = "<p>Hello world!</p>" 

[kolibril13]

Ah nice!
Then I need document.body.innerText, I will change that!

[KekOnTheWorld]

This should be fixed now. Can you close this issue?

[Rickaym]

Yep, thanks.

Ricky.