Coder Social home page Coder Social logo

Comments (6)

ben-eb avatar ben-eb commented on July 21, 2024

Just realised that the view ends up being removed before the close function gets called so the plugin isn't properly cleaned up, so I fixed the error on my end by calling the stop method. However it would still be nice to be able to remove the plugin from an element in any case.

from vticker.

richhollis avatar richhollis commented on July 21, 2024

Hi @ben-eb - so just one method call to remove and unbind? Is that essentially what were talking about here?

from vticker.

ben-eb avatar ben-eb commented on July 21, 2024

Essentially, yes; I'd expect such a method call to return the element to the state it was in before vTicker was called, kind of like fullCalendar's way of doing it:

    function destroy() {

        if (currentView) {
            trigger('viewDestroy', currentView, currentView, currentView.element);
            currentView.triggerEventDestroy();
        }

        $(window).unbind('resize', windowResize);

        header.destroy();
        content.remove();
        element.removeClass('fc fc-rtl ui-widget');
    }

http://arshaw.com/fullcalendar/docs/display/destroy/

from vticker.

richhollis avatar richhollis commented on July 21, 2024

Ok, sounds like a good idea. I'll look at adding.

from vticker.

richhollis avatar richhollis commented on July 21, 2024

v1.14 adds remove method.

from vticker.

ben-eb avatar ben-eb commented on July 21, 2024

Great, thank you for resolving it so quickly. 👍

from vticker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.