Coder Social home page Coder Social logo

Comments (4)

richardpenman avatar richardpenman commented on August 31, 2024 2

sorry I would like to keep python2 - some people aren't able to upgrade

from whois.

elderlabs avatar elderlabs commented on August 31, 2024 1

Python 3.12 is coming. It will drop all support for imp, thus I must suggest a compromise.

Many packages maintain support for the long-deprecated Python2 without the use of imp. While I myself do not, there are alternative means to maintaining support for both sides, otherwise python-whois will end with the release of Python 3.12. As I and many others would not like to see that, I'd like to correct this issue somewhere in the pipeline.

Packages like six might offer some amount of support, though I have not checked. I'll look into correcting the issue in python-future directly, though testing the patch would be fairly impossible as I do not use it myself.

from whois.

elderlabs avatar elderlabs commented on August 31, 2024

I reached out to the python-future team when I originally replied to this issue. Years later, they still haven't updated their project, which projects like this one depend upon. Python 3.12 is approaching very soon. There's been an open PR in python-future to fix the issue since 2019.

We have two options, it would appear. Either python-whois migrates to a fork of python-future, or python-whois ends with Python 3.12, in favor of supporting the long deprecated and unsupported Python 2.

There's nothing stopping development here. We can gracefully break step from Python 2 with a version number increase. Releases for Python 2 can remain on an older version number (mostly for security patching), while development for Python 3 can continue.

If it were me, and dropping Python 2 years after its retirement wasn't an option, I'd do as I've done before. Grab a fork of python-future that's not dead, or fork python-future yourself and merge that PR, no additional work needed. It will keep python-whois alive exponentially longer, and maintain unbreaking support for both Python 2 and Python 3.

I do not want to see this project die, as I do still depend on it. I hope that I can still depend upon it when Python 3.12 is released. @richardpenman perhaps one of the few options I've noted here would work for you, particularly my final note about forking.

Thanks.

EDIT: so I looked into python-future. It looks like a patch might have been pushed in version 0.18.3, but the PR left open. Perhaps my Python virtual-env is outdated. Will report back if it's patched. Surprised that didn't occur to me sooner. Thing is, I install package updates frequently, so I'm not certain why future would still be an old version.

EDIT 2: So I rebuilt my venv with the latest of everything. The imp deprecation is still present. It would seem this issue still goes unfixed.

from whois.

AngellusMortis avatar AngellusMortis commented on August 31, 2024

Just another bump on this. Python 3.12 comes out in less then 3 months. This package and everything that uses it will stop working unless this deprecation is fixed.

from whois.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.